Skip to content

Fix OID issues #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 7, 2018
Merged

Fix OID issues #430

merged 4 commits into from
Sep 7, 2018

Conversation

@sjaeckel
Copy link
Member

@sjaeckel sjaeckel commented Jul 16, 2018 •
edited
Loading

This fixes

  1. the decoding of OID's in the root-node 2
  2. the possibility to encode OID's with a root-node of 3

@sjaeckel sjaeckel modified the milestones: next, v1.18.3 Jul 16, 2018
@sjaeckel sjaeckel changed the title Fix/oid decode Fix OID issues Jul 16, 2018
@sjaeckel sjaeckel requested a review from karel-m September 6, 2018 16:36
@sjaeckel
add OID testcase from x.690
079ed04
@sjaeckel
fix der_decode_object_identifier()
4ffdb91
@sjaeckel
add another OID testcase for root-node 3
6584569
@sjaeckel
fix der_length_object_identifier()
2e9c80c 
... there are only three root nodes

As of X6.90 Ch. 8.19.4: "NOTE – This packing of the first two
object identifier components recognizes that only three values
are allocated from the root node..."
@sjaeckel sjaeckel merged commit 86ff141 into develop Sep 7, 2018
@sjaeckel sjaeckel deleted the fix/oid-decode branch September 7, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karel-m karel-m karel-m approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.18.3

Development

Successfully merging this pull request may close these issues.

3 participants

@sjaeckel @karel-m