Streams - add single call crypt functions #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaeckel
requested changes
Sep 6, 2018
src/stream/chacha/chacha_test.c
Outdated
| if ((err = chacha_ivctr64(&st, n + 4, sizeof(n) - 4, 1)) != CRYPT_OK) return err; | ||
| if ((err = chacha_crypt(&st, (unsigned char*)pt, len, out)) != CRYPT_OK) return err; | ||
| if (compare_testvector(out, len, ct, sizeof(ct), "CHACHA-TV3", 1)) return CRYPT_FAIL_TESTVECTOR; | ||
| /* crypt in a single call using 64-bit counter with a value of 1 */ |
Member
There was a problem hiding this comment.
Can you please add a second testcase that also hits chacha_ivctr32().
fix mixed declarations and code add _memory chacha_ivctr32() test
sjaeckel
force-pushed
the
streams-add-single-call-crypt-functions
branch
from
b31130f to
13bc14d
Compare
Member
|
I took the freedom to rebase everything on top of develop and clean up the duplicate commits :) |
sjaeckel
force-pushed
the
streams-add-single-call-crypt-functions
branch
from
13bc14d to
a2b343b
Compare
Contributor
Author
|
On 10Sep, 2018, at 2:37 AM, Steffen Jaeckel ***@***.***> wrote:
I took the freedom to rebase everything on top of develop and clean up the duplicate commits :)
Thanks. ...but the git log graph looks funny. ...and certainly not like it was after my rebase/squash. ??? May I assume it is fixable? ...how?
|
sjaeckel
reviewed
Sep 10, 2018
Member
sjaeckel
left a comment
sjaeckel
left a comment
There was a problem hiding this comment.
I think we should include these xx_memory() implementations in the single c files where there's only a single file for now!
@karel-m what do you think?
@buggywhip sorry, I didn't see that before!
Member
I am for keeping |
Member
|
Good point I didn't think about! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added single-call crypt functions to each of the stream ciphers using the <cipher>_memory() naming convention.
Checklist