Skip to content

Avoid LTC_ARGCHK in void functions #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2018
Merged

Avoid LTC_ARGCHK in void functions #459

merged 1 commit into from
Oct 27, 2018

Conversation

@karel-m
Copy link
Member

@karel-m karel-m commented Oct 26, 2018

By default LTC_ARGCHK never returns (it aborts).

However, with ARGTYPE == 4 it calls return CRYPT_INVALID_ARG which causes compiler warnings.

@karel-m karel-m requested a review from sjaeckel October 26, 2018 15:42
@sjaeckel
Copy link
Member

sjaeckel commented Oct 26, 2018

that's why there's also LTC_ARGCHKVD() :)

@karel-m karel-m force-pushed the pr/copy_or_zeromem branch from 4cf8f9d to 058a7e2 Compare October 26, 2018 17:35
@karel-m
Copy link
Member Author

karel-m commented Oct 26, 2018

Fixed

@sjaeckel
Copy link
Member

sjaeckel commented Oct 26, 2018

Approved

@karel-m karel-m merged commit 983fd25 into develop Oct 27, 2018
@karel-m karel-m deleted the pr/copy_or_zeromem branch October 29, 2018 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjaeckel sjaeckel Awaiting requested review from sjaeckel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karel-m @sjaeckel