Skip to content

Conversation

karel-m
Copy link
Member

@karel-m karel-m commented Sep 1, 2024

Fix for #663

  • Static functions renamed (using s_ prefix) so that they do not collide with cygwin stuff
  • Added missing #ifdef LTC_TEST

@karel-m karel-m requested review from levitte and sjaeckel September 1, 2024 09:21
Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like that we also would prevent name clashes as seen when trying to do #596 and the names are still kind of the same from the original and not something entirely different.

@karel-m karel-m force-pushed the pr/fix-sm4-on-cygwin branch from 1bf2e71 to 24e31ef Compare September 1, 2024 16:59
Copy link
Collaborator

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karel-m karel-m requested a review from sjaeckel September 1, 2024 18:07
@sjaeckel sjaeckel merged commit e8eb4a0 into develop Sep 2, 2024
75 checks passed
@sjaeckel sjaeckel deleted the pr/fix-sm4-on-cygwin branch September 2, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants