No grow in mp_set_int* (2) #252
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* mp_set_int* always return MP_OKAY * remove return checks for mp_set_int* * introduce MP_ROUND_TO_PREC, which rounds up to precision * introduce MP_MIN_SIZE
Member
|
can you please also fix the travis.yml so it doesn't start two builds if the branch starts with travis/ or is that intended? |
Member
Author
|
It was intended. I wanted to test both commits. But doesn't matter, we can restart this at some other time. The CI is too slow :( |
Member
Author
|
But I am not sure if travis starts every run twice for PR branches called travis/. I just had this branch as travis/ first for CI to run. It is probably a bad idea to have PR branches called travis. |
Member
yep, that's what I meant but I like the idea of having a way to test separate commits! |
Member
Author
Yes, therefore I called it originally like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #221, I tried to simplify some things. No padding to MP_PREC anymore. Ping @nijtmans