Removed obsolete code #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
czurnieden
force-pushed
the
clang_tidy_reaction
branch
from
00451c7 to
7b157d6
Compare
minad
reviewed
Jun 13, 2019
czurnieden
commented
Jun 13, 2019
Contributor
Author
czurnieden
left a comment
czurnieden
left a comment
There was a problem hiding this comment.
Why the … do I have to review my own commit?
Is this UI gone completely bonkers now or is it just me?
minad
approved these changes
Jun 13, 2019
sjaeckel
approved these changes
Jun 30, 2019
sjaeckel
force-pushed
the
clang_tidy_reaction
branch
from
7b157d6 to
1803417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@karel-m run
clang-tidyand found several things (vid.: #317 ). Two of them are actually obsolete code and this PR removes them.That code was in cryptographically sensitive parts of LTM, so a second (or more) opinion about the correctness would be highly appreciated!