Skip to content

Corrected type for the sign-handling in bit-banger div #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
czurnieden wants to merge 1 commit into from
Closed

Corrected type for the sign-handling in bit-banger div #392

czurnieden wants to merge 1 commit into from

Conversation

@czurnieden
Copy link
Contributor

@czurnieden czurnieden commented Oct 19, 2019

Attended the undeservedly neglected bit-banger division.

@minad minad self-requested a review October 20, 2019 07:12
@minad minad added the finished label Oct 20, 2019
@minad
Copy link
Member

minad commented Oct 20, 2019

Could you add this to #370 instead?

@minad minad closed this Oct 20, 2019
@czurnieden
Copy link
Contributor Author

czurnieden commented Oct 20, 2019

Could you add this to #370 instead?

At one time you insist on sliceing the PR and here you insist on combining them.
You're killing me.
*sigh*

No, just kidding, I've put it already in #370 this morning, this PR was an excerpt because I thought you want those PRs individually.

@sjaeckel sjaeckel removed the finished label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minad minad minad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@czurnieden @minad @sjaeckel