Skip to content

Conversation

@cntrump
Copy link
Contributor

@cntrump cntrump commented Nov 25, 2021

No description provided.

@sjaeckel
Copy link
Member

I'm not sure if this belongs here, shouldn't this be tracked in some swift package repository?

@cntrump
Copy link
Contributor Author

cntrump commented Nov 25, 2021

I'm not sure if this belongs here, shouldn't this be tracked in some swift package repository?

If this repo add SPM support, others can directly add a reference to this repository.

// swift-tools-version:5.0
// The swift-tools-version declares the minimum version of Swift required to build this package.
import PackageDescription

let package = Package(
...
    dependencies: [
        // Dependencies declare other packages that this package depends on.
        .package(url: "https://github.com/libtom/libtommath.git", .branch("master")),
    ],
...
)

shouldn't this be tracked in some swift package repository?

SPM is a decentralized dependency package manager. If repo not support SPM, thats how they use it https://github.com/cntrump/SwiftTomCrypt

@royjit
Copy link

royjit commented Nov 26, 2021

We would like to have this feature as well. I was able to successfully test this change in a Swift library that I am working

@sjaeckel
Copy link
Member

OK, could you maybe add a short example to the demo folder with a little bit of documentation on how to use it?

Do you also plan to add the same to ltc?

@cntrump
Copy link
Contributor Author

cntrump commented Nov 28, 2021

Do you also plan to add the same to ltc?

Yes, I will commit a SwiftPM support PR for libtomcrypt after this PR merged.

OK, could you maybe add a short example to the demo folder with a little bit of documentation on how to use it?

OK, I will try.

@cntrump
Copy link
Contributor Author

cntrump commented Dec 1, 2021

Do you also plan to add the same to ltc?

Done.

@sjaeckel
Copy link
Member

sjaeckel commented Dec 1, 2021

Wow, that's more than I expected :)

Huge 👍

@sjaeckel sjaeckel merged commit f692782 into libtom:develop Dec 1, 2021
@royjit
Copy link

royjit commented Jan 7, 2022

Do you have plans to tag this as a release soon? I see that the last tagged release was on Oct 2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants