Fix -Wimplicit-function-declaration#4
Merged
sjaeckel merged 1 commit intolibtom:developfrom Nov 7, 2022
thesamesam:develop
Merged
Fix -Wimplicit-function-declaration#4sjaeckel merged 1 commit intolibtom:developfrom thesamesam:develop
sjaeckel merged 1 commit intolibtom:developfrom
thesamesam:develop
Conversation
Contributor
Author
|
@sjaeckel could you possibly take a look? thanks |
sjaeckel
requested changes
Nov 5, 2022
Member
sjaeckel
left a comment
sjaeckel
left a comment
There was a problem hiding this comment.
Sorry, I completely missed this PR!
PR looks fine besides this one remark.
Clang 16 will make -Wimplicit-function-declaration error by default. For more information, see LWN.net [0] or LLVM's Discourse [1], gentoo-dev@ [2], or the (new) c-std-porting mailing list [3]. [0] https://lwn.net/Articles/913505/ [1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213 [2] https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240 [3] hosted at lists.linux.dev. Bug: https://bugs.gentoo.org/875527 Signed-off-by: Sam James <sam@gentoo.org>
sjaeckel
approved these changes
Nov 7, 2022
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Causes build failures with Clang 16.
Bug: https://bugs.gentoo.org/875527
Signed-off-by: Sam James sam@gentoo.org