Cleanup Windows backend code a bit#305
Merged
Youw merged 3 commits intolibusb:masterfrom Jul 16, 2021
Merged
Conversation
Contributor
Author
|
@Youw could you please review this? |
Youw
reviewed
Jul 14, 2021
Member
Youw
left a comment
Youw
left a comment
There was a problem hiding this comment.
So now we open the device/handle 2 times during the enumeration.
I'd strongly suggest to cache/reuse the same handle, even if some of the sub-routines are in a separate function.
Youw
approved these changes
Jul 15, 2021
Contributor
Author
|
@Youw could you merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup Windows backend code a bit before adding HID device connection callback code.