Fixed Visual C++ warning C4214#602
Merged
Youw merged 1 commit intolibusb:masterfrom Jul 29, 2023
Merged
Conversation
Member
|
What is the original warning? That struct has to be 100% ABI stable. It is reversed-engineered, based on some pieces found online. Please see that the CI build is failing. I'd consider explicitly supressing some warnings, instead of changing types as suggested in this PR. |
Contributor
Author
|
Okay, I'll make that change instead. I think the change of BOOLEAN to UINT may be incorrect here. |
slouken
force-pushed
the
bit-field-types-other-than-int
branch
from
f4de7f5 to
23db93d
Compare
…eld types other than int
slouken
force-pushed
the
bit-field-types-other-than-int
branch
from
23db93d to
a072978
Compare
Youw
approved these changes
Jul 25, 2023
Member
|
thanks |
cmorty
added a commit
to cmorty/hidapi
that referenced
this pull request
Nov 16, 2023
…: bit field types other than int (libusb#602)" This reverts commit 98ab22a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.