macOS: Check for macOS 10.10 using kCFCoreFoundationVersionNumber instead of AppKit#611
macOS: Check for macOS 10.10 using kCFCoreFoundationVersionNumber instead of AppKit#611Youw merged 1 commit intolibusb:masterfrom
Conversation
…tead of AppKit Fixes: libusb#587
|
This looks perfect. |
|
Yes, this should work -- the issue only manifests when linked against AppKit. Thanks! |
Would you be able to actually run and check? |
|
We've patched out this version check entirely as we don't need to support macOS predating 10.10. However the minimal repro code for the (still open) Apple bug only has problems when AppKit is linked in. CoreFoundation and IOKit are fine. |
Youw
left a comment
Youw
left a comment
There was a problem hiding this comment.
I wasn't able to reproduce the original #587 with current master. Maybe because I'm using M2 mac machine. Thus I cannot confirm if it really fixes the original issue or not.
@mrpippy can you confirm that you had the original issue reproduced locally and not reproducible after this change?
In any case - this make one dependency less compared to "before" which is a great thing on its own.
3 participants
Fixes: #587