Skip to content

windows: fix LNK4006 duplicate symbol warning in static CMake builds #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youw merged 2 commits into from
May 20, 2026
+9 −1
Merged

windows: fix LNK4006 duplicate symbol warning in static CMake builds #809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2471001
Initial plan
Copilot May 19, 2026
8a8b080
Fix LNK4006 duplicate symbol warning in Windows static CMake builds
Copilot May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions windows/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ target_link_libraries(hidapi_winapi
PUBLIC hidapi_include
)

target_compile_definitions(hidapi_winapi
# CMake compiles hidapi_descriptor_reconstruct.c as a separate translation unit,
# so hid.c must not #include it (to avoid duplicate symbol LNK4006 in static builds).
PRIVATE HIDAPI_CMAKE_V0_BUILD
)

if(NOT BUILD_SHARED_LIBS)
target_compile_definitions(hidapi_winapi
# prevent marking functions as __declspec(dllexport) for static library build
Expand Down
4 changes: 3 additions & 1 deletion windows/hid.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1607,7 +1607,9 @@ HID_API_EXPORT const wchar_t * HID_API_CALL hid_error(hid_device *dev)
return last_global_error_str;
}

#ifndef hidapi_winapi_EXPORTS
#ifndef HIDAPI_CMAKE_V0_BUILD
/* Include the descriptor reconstruction code when NOT building with CMake.
CMake builds compile hidapi_descriptor_reconstruct.c as a separate translation unit. */
#include "hidapi_descriptor_reconstruct.c"
#endif

Expand Down
Loading