Revert "darwin: speed up uv_set_process_title()"#2568
Merged
bnoordhuis merged 3 commits intolibuv:v1.xfrom Dec 16, 2019
Merged
Conversation
cjihrig
approved these changes
Dec 8, 2019
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM.
Argh, the test is still failing on one of the CI macs though :-/
Member
Author
|
Let's see what halving the iteration count does: https://ci.nodejs.org/job/libuv-test-commit/1659/ |
Contributor
|
mac CI is green! |
saghul
approved these changes
Dec 10, 2019
This reverts commit bee1bf5. This is necessary in order to be able to revert commit 038eacf ("darwin: speed up uv_set_process_title()") from October. PR-URL: libuv#2568 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
This reverts commit 038eacf. It was reported that this change causes a regression when trying to obtain the screen resolution with `CGDisplayPixelsWide()` or `CGDisplayPixelsHigh()` after changing the process title. This is the second time this change had to be reverted due to regressions and, although third time is allegedly the charm, leaving well enough alone is the proverb I plan to adhere to... Fixes: libuv#2566 PR-URL: libuv#2568 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Stop dlsym-ing the symbol name at run-time, that was only necessary to support macOS and iOS versions that were already near-obsolete when this feature was introduced in August 2013. This reapplies commit bee1bf5 from October. PR-URL: libuv#2568 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Member
Author
|
Thanks all for reviewing, landed in f0923d0...d077d06. |
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
This reverts commit bee1bf5. This is necessary in order to be able to revert commit 038eacf ("darwin: speed up uv_set_process_title()") from October. PR-URL: libuv/libuv#2568 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
This reverts commit 038eacf. It was reported that this change causes a regression when trying to obtain the screen resolution with `CGDisplayPixelsWide()` or `CGDisplayPixelsHigh()` after changing the process title. This is the second time this change had to be reverted due to regressions and, although third time is allegedly the charm, leaving well enough alone is the proverb I plan to adhere to... Fixes: libuv/libuv#2566 PR-URL: libuv/libuv#2568 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
Stop dlsym-ing the symbol name at run-time, that was only necessary to support macOS and iOS versions that were already near-obsolete when this feature was introduced in August 2013. This reapplies commit bee1bf5 from October. PR-URL: libuv/libuv#2568 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
This reverts commit bee1bf5. This is necessary in order to be able to revert commit 038eacf ("darwin: speed up uv_set_process_title()") from October. PR-URL: libuv/libuv#2568 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
This reverts commit 038eacf. It was reported that this change causes a regression when trying to obtain the screen resolution with `CGDisplayPixelsWide()` or `CGDisplayPixelsHigh()` after changing the process title. This is the second time this change had to be reverted due to regressions and, although third time is allegedly the charm, leaving well enough alone is the proverb I plan to adhere to... Fixes: libuv/libuv#2566 PR-URL: libuv/libuv#2568 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
Stop dlsym-ing the symbol name at run-time, that was only necessary to support macOS and iOS versions that were already near-obsolete when this feature was introduced in August 2013. This reapplies commit bee1bf5 from October. PR-URL: libuv/libuv#2568 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 038eacf.
It was reported that this change causes a regression when trying
to obtain the screen resolution with
CGDisplayPixelsWide()orCGDisplayPixelsHigh()after changing the process title.This is the second time this change had to be reverted due to
regressions and, although third time is allegedly the charm,
leaving well enough alone is the proverb I plan to adhere to...
Fixes: #2566
CI: https://ci.nodejs.org/job/libuv-test-commit/1657/