osx,fsevent: fix race during uv_loop_close#2626
Merged
vtjnash merged 2 commits intolibuv:v1.xfrom Jan 21, 2020
Merged
Conversation
saghul
reviewed
Jan 14, 2020
| state->signal_source, | ||
| *pkCFRunLoopDefaultMode); | ||
|
|
||
| state->loop = NULL; |
Member
There was a problem hiding this comment.
we were not resetting this before?
Member
There was a problem hiding this comment.
It also looks like a race condition to me since it's modified without holding the mutex. uv__cf_loop_signal() reads it and runs on the other thread.
Member
Author
There was a problem hiding this comment.
We weren't—in fact, we should never use or read this field again after this point in the code (we also never branch on it being NULL). The mistake was that we sometimes would (because we didn't hold the necessary mutex). Clearing it here just helps to makes any bad concurrent usage more obvious.
bnoordhuis
approved these changes
Jan 16, 2020
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM but can I suggest splitting this into two commits so it's clear from history that state->loop = NULL is not part of the bug fix?
vtjnash
added a commit
to vtjnash/libuv
that referenced
this pull request
Jan 16, 2020
The mutex also needs to protect the access to the state->loop variable, since that's owned by the child thread and will be destroyed as soon as it processes our message. Fixes: libuv#2625 PR-URL: libuv#2626 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
vtjnash
added a commit
to vtjnash/libuv
that referenced
this pull request
Jan 16, 2020
Set this to NULL just before disposing it to make mistakes more painfully obvious, hopefully. PR-URL: libuv#2626 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Member
Author
The mutex also needs to protect the access to the state->loop variable, since that's owned by the child thread and will be destroyed as soon as it processes our message. Fixes: libuv#2625 PR-URL: libuv#2626 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Set this to NULL just before disposing it to make mistakes more painfully obvious, hopefully. PR-URL: libuv#2626 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
The mutex also needs to protect the access to the state->loop variable, since that's owned by the child thread and will be destroyed as soon as it processes our message. Fixes: libuv/libuv#2625 PR-URL: libuv/libuv#2626 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
Set this to NULL just before disposing it to make mistakes more painfully obvious, hopefully. PR-URL: libuv/libuv#2626 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
The mutex also needs to protect the access to the state->loop variable, since that's owned by the child thread and will be destroyed as soon as it processes our message. Fixes: libuv/libuv#2625 PR-URL: libuv/libuv#2626 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
Set this to NULL just before disposing it to make mistakes more painfully obvious, hopefully. PR-URL: libuv/libuv#2626 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mutex also needs to protect the access to the state->loop variable,
since that's owned by the child thread and will be destroyed as soon as
it processes our message.
This previously caused shutdown of libuv loops (especially the stress test fs_event_error_reporting) to segfault occasionally.
Fixes: #2625