unix: fix uv__udp_recvmsg crash#5131
Merged
Merged
Conversation
Member
|
@juanarbol that suggests the fix from b030b02 is incomplete? Can you review? |
Member
Looks like it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handle can be actived when
handle->recv_cbisNULL(interested inPOLLOUTevent, see uv__udp_recv_stop), so i think we should also checkhandle->recv_cb.cc @juanarbol
assert failed: https://github.com/nodejs/node/actions/runs/24960336330/job/73085918658?pr=62971