-
Notifications
You must be signed in to change notification settings - Fork 11
Prefer use of gtk_snapshot_set_snap()
#47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Well done for finding that gtk PR! I'll make a matching issue on nip4, since it'll need this too. |
|
I've fixed this in the Windows builds with commit libvips/build-win64-mxe@886f9a1, as we have full control over how GTK is built there. |
|
Oh, that's great! I've finally fixed the focus highlight in git master vipsdisp too, so it should be a lot prettier. It's all animated with CSS now! |
see libvips/vipsdisp#47 thanks @kleisauke!
|
I put a version of this PR into nip4 behind a feature detect in meson. Thank you! |
|
Great! I made the same change here. This is ready for review now, there's no need to wait for the upstream PR. |
|
Great! Yes, I did the win build of nip4 without this, unfortunately :( Perhaps I'll update vipsdisp and get it in that way. |
|
... I suppose we could add libraw to the win build too, that might be fun to experiment with. I've no idea how easy it is to build though. |
|
Ah, I'll probably need to re-baseline those patches for the Windows builds now too. Adding libraw would hopefully be straightforward. |
|
Hopefully the vipsdisp patch for snapshot snap can just go now. It looks like the gtk patches will need some work :( it's still in flux, looking at the PR. |
|
I updated vipsdisp (again) from nip4 to get the new tilecache. It should be a bit faster and prettier. |

See: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/8494
Context: #46 (comment)