Skip to content

Conversation

@kleisauke
Copy link
Member

@kleisauke kleisauke commented Jun 22, 2025

@jcupitt
Copy link
Member

jcupitt commented Jun 22, 2025

Well done for finding that gtk PR! I'll make a matching issue on nip4, since it'll need this too.

@jcupitt
Copy link
Member

jcupitt commented Jun 22, 2025

Here's nip4 (which has the same tile overlap issue) with Image / Patterns / Zone plate, fwiw:

image

Ouch!

@kleisauke
Copy link
Member Author

I've fixed this in the Windows builds with commit libvips/build-win64-mxe@886f9a1, as we have full control over how GTK is built there.

@jcupitt
Copy link
Member

jcupitt commented Jun 28, 2025

Oh, that's great!

I've finally fixed the focus highlight in git master vipsdisp too, so it should be a lot prettier. It's all animated with CSS now!

93fba29

jcupitt added a commit to libvips/nip4 that referenced this pull request Jul 23, 2025
@jcupitt
Copy link
Member

jcupitt commented Jul 23, 2025

I put a version of this PR into nip4 behind a feature detect in meson. Thank you!

@kleisauke
Copy link
Member Author

kleisauke commented Jul 23, 2025

Great! I made the same change here.

This is ready for review now, there's no need to wait for the upstream PR.

@kleisauke kleisauke marked this pull request as ready for review July 23, 2025 14:47
@jcupitt jcupitt merged commit 034afd8 into libvips:master Jul 23, 2025
1 check passed
@kleisauke kleisauke deleted the snappy branch July 23, 2025 14:48
@jcupitt
Copy link
Member

jcupitt commented Jul 23, 2025

Great!

Yes, I did the win build of nip4 without this, unfortunately :( Perhaps I'll update vipsdisp and get it in that way.

@jcupitt
Copy link
Member

jcupitt commented Jul 23, 2025

... I suppose we could add libraw to the win build too, that might be fun to experiment with. I've no idea how easy it is to build though.

@kleisauke
Copy link
Member Author

Ah, I'll probably need to re-baseline those patches for the Windows builds now too. Adding libraw would hopefully be straightforward.

@jcupitt
Copy link
Member

jcupitt commented Jul 23, 2025

Hopefully the vipsdisp patch for snapshot snap can just go now. It looks like the gtk patches will need some work :( it's still in flux, looking at the PR.

@jcupitt
Copy link
Member

jcupitt commented Jul 23, 2025

I updated vipsdisp (again) from nip4 to get the new tilecache. It should be a bit faster and prettier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants