Fix high dpi2 #52
Merged
Fix high dpi2 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
though mag display and compute needs doing too
Member
Author
|
Ah, enclosing our highdpi drawing in save/restore fixes the focus rect |
kleisauke
reviewed
Jul 31, 2025
Co-authored-by: Kleis Auke Wolthuizen <github@kleisauke.nl>
Member
Author
|
I'm seeing: Dragging a window between desktops with different density, but that's probably a gtk issue. |
Member
|
Works great on Fedora 42 as well! Tested both with and without those |
Member
Author
|
That's great! I'll make another test release to make win builds easier. |
clip clients, client should use regular coordinate space
Member
Author
|
I added some win binaries to that test release https://github.com/jcupitt/vipsdisp/releases/tag/v4.1.0-high-dpi2 |
Member
Author
|
Friends with 4k win displays are saying it's working fine! The binary I made is with your gtk patch |
Member
|
I can confirm it works fine on Windows with various desktop scaling settings! |
Member
Author
|
that was very painful! thank you for all the code / review / testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at highdpi support. This one seems to work!
The remaining issue I've noticed is the focus rectangle. It does not scale with display density, so you can get eg.: