Merged
Conversation
Use a natural ordering on Move rather than an external comparator. This improves readability, but also jmh benchmarks by about 10%.
Member
|
I don't see the benchmark improvement at all (running with lots of forks to deal with the bimodal distribution). But it is more readable ... |
Member
Author
|
jmh on HuffmanPgnBench.decode is oddly bimodal. During a fork's runs, the times are consistent, but different forks/runs are not consistent. before PR:
with PR:
So, on my machine, the 'good' runs are 10% faster locally, and the 'bad' runs are about 5% faster. |
Member
Author
|
But this is the second PR here where I saw improvements locally and the other person didn't... so idk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a natural ordering on Move rather than an external comparator. This improves readability, but also jmh benchmarks by about 10%.