Skip to content

Add SimpleDVT module #201

Merged
krogla merged 76 commits into
masterfrom
large-vote_simple_dvt
Feb 23, 2024
Merged

Add SimpleDVT module #201
krogla merged 76 commits into
masterfrom
large-vote_simple_dvt

Conversation

@krogla
Copy link
Copy Markdown
Member

@krogla krogla commented Feb 15, 2024

  • added module via voting
  • updated tests to support 2nd staking module

@krogla krogla mentioned this pull request Feb 15, 2024
@krogla krogla requested a review from a team as a code owner February 19, 2024 10:12
Copy link
Copy Markdown
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a few nitpicks 🙏

Comment thread .github/actions/brownie_fork_tests/action.yml
Comment thread configs/config_mainnet.py
Comment thread configs/config_mainnet.py
Comment thread scripts/vote_simple_dvt.py Outdated
Comment thread scripts/vote_simple_dvt.py Outdated
Comment thread tests/test_vote_simple_dvt.py Outdated
Comment thread tests/test_vote_simple_dvt.py
Comment thread tests/test_vote_simple_dvt.py
Copy link
Copy Markdown
Member

@folkyatina folkyatina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tests/acceptance/test_simple_dvt_module.py
Comment thread tests/regression/test_accounting_oracle_extra_data_full_items.py
Copy link
Copy Markdown
Member

@bulbozaur bulbozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. covers testplan

@krogla krogla merged commit ab02757 into master Feb 23, 2024
@krogla krogla deleted the large-vote_simple_dvt branch February 23, 2024 15:47
@krogla krogla restored the large-vote_simple_dvt branch February 23, 2024 16:57
iamnp added a commit that referenced this pull request May 7, 2026
Copilot AI mentioned this pull request May 11, 2026
iamnp added a commit that referenced this pull request May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants