Merged
Conversation
added 3 commits
December 12, 2022 14:09
Collaborator
|
@egenc looks good! Could you fix the conflicts before I can approve? |
Contributor
Author
|
@danielboloc , I have fixed the conflict, could you please review? |
danielboloc
reviewed
Dec 29, 2022
Collaborator
danielboloc
left a comment
danielboloc
left a comment
There was a problem hiding this comment.
@egenc I would leave all response status as 200
Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com>
Contributor
Author
|
thanks @danielboloc , ready to merge now. |
danielboloc
approved these changes
Dec 30, 2022
dapineyro
added a commit
that referenced
this pull request
Feb 21, 2023
* feat: add `--request-interval` parameter (#93) * feat(parameters): add parameter for customization. See #90 * docs: add documentation in changelog and readme * bump: increse minor version 1.0.0 to 1.1.0 * refactor: replace command line option from cromwell with constant variable * docs: update about request interval option * refactor: add control expression to not surpass wait time * refactor: change variable to the constant for Cromwell jobs * Adds ssl verification control (#103) * Docs patch for SSL functionality (#106) * Update README.md Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Update README.md Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Change default cost limit 30 $ (#102) * Add new cost limit as default 30$ * CHANGELOG updated * VERSION updated * Update cloudos/__main__.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * version update * Update README.md * version bump to 1.2.1 Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Christina Chatzipantsiou <38183826+cgpu@users.noreply.github.com> Co-authored-by: dapineyro <dapineyro.dev@gmail.com> * Feat: make --wdl-importsFile optional (#98) * fix BadRequestException #84 * make wdl-importsfile optional * update docs * simplify code * simplify code 2 * simplify code 3 * simplify code 4 * small doc change * fix repo for projects * Update to prepare a release * Adds api key support for cromwell (#104) * fix BadRequestException #84 * make wdl-importsfile optional * update docs * simplify code * simplify code 2 * simplify code 3 * simplify code 4 * small doc change * fix repo for projects * Use API key when no cromwell key is available * Adds click support * small help change * Updates docs * Minor doc changes * Remove cromwell_token * Pytests added for _create_cromwell_header function (#114) * Pytests added for _create_cromwell_header function * unused code removed * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * new folder for cloudos tests * init Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * test: add tests for 'get_job_list' (#116) * test: add tests for 'get_job_list' * refactor: add new assert statement * refactor: apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * style: move to proper folder * style: update tests/test_clos/test_get_job_list.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Fix: resolve JSON error in error message handling (#124) * fix error messages * Bump version to v1.3.1 * correct pytests using BadRequestException * Pytest for BadRequestException Class (#126) * pytest for BadRequestException * renamed function * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * requested changes * test moved to folder Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Pytest added for function project_id (#120) * pytest for function project_id * script updated * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * module docstring added * Update test_project_id.py * requested changes * Update tests/test_clos/test_project_id.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for function detect_workflow (#119) * proper json added * pytest function added * script updated for proper workflow name * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * import added * module docstring * Update tests/test_clos/test_detect_workflow.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * pytest added for output workflow_id (#121) * pytest added for output workflow_id * Object Class is modified to Job * values are masked * json update, assert update * module docstring added * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * requested changes Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest workflow (#132) * pytest added for output workflow_id * Object Class is modified to Job * values are masked * json update, assert update * module docstring added * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * requested changes Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for function process_workflow_list (#118) * Pytest for process_workflow_list added * file moved to test_clos folder * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * updated functions * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * code improvement * Update tests/test_clos/test_process_workflow_list.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Update tests/test_clos/test_process_workflow_list.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * test: adds tests for 'get_workflow_list' (#117) * test: add tests for 'get_workflow_list' method * refactor: apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * test: update bad request code and workflows .json * move test to proper folder * style: remove comment line * test: add workflows .json file Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for TimeOutException Class (#127) * pytest timeoutexception * descr update * Update test_timeout_exception.py * test moved to folder Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> * Pytest for send_job (#129) * Pytest for send_job * code improvment * update * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Pytest added for function get_cromwell_status (#123) * Pytest added for function get_cromwell_status * code layout fix * Update test_get_cromwell_status.py * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Pytest added for function ssl_selector (#122) * Pytest added for function ssl_selector * code improvements * test added for check ssl cert is a file * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * requested changes are made * blank Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest for cromwell_switch (#128) * Pytest for cromwell_switch * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for function get_job_status (#125) * pytest get_job_status * naming * out message fix * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * proper request json added * print removed * job status assertion update * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Fix: adapt to new projects api (#135) * fix the new api while maintaining backwards compatibility * update docs * update README.md date * remove cb (#136) --------- Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: Christina Chatzipantsiou <38183826+cgpu@users.noreply.github.com> Co-authored-by: egenc <erdal.genc09@gmail.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local>
dapineyro
added a commit
that referenced
this pull request
Mar 8, 2023
* feat: add `--request-interval` parameter (#93) * feat(parameters): add parameter for customization. See #90 * docs: add documentation in changelog and readme * bump: increse minor version 1.0.0 to 1.1.0 * refactor: replace command line option from cromwell with constant variable * docs: update about request interval option * refactor: add control expression to not surpass wait time * refactor: change variable to the constant for Cromwell jobs * Adds ssl verification control (#103) * Docs patch for SSL functionality (#106) * Update README.md Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Update README.md Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Change default cost limit 30 $ (#102) * Add new cost limit as default 30$ * CHANGELOG updated * VERSION updated * Update cloudos/__main__.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * version update * Update README.md * version bump to 1.2.1 Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Christina Chatzipantsiou <38183826+cgpu@users.noreply.github.com> Co-authored-by: dapineyro <dapineyro.dev@gmail.com> * Feat: make --wdl-importsFile optional (#98) * fix BadRequestException #84 * make wdl-importsfile optional * update docs * simplify code * simplify code 2 * simplify code 3 * simplify code 4 * small doc change * fix repo for projects * Update to prepare a release * Adds api key support for cromwell (#104) * fix BadRequestException #84 * make wdl-importsfile optional * update docs * simplify code * simplify code 2 * simplify code 3 * simplify code 4 * small doc change * fix repo for projects * Use API key when no cromwell key is available * Adds click support * small help change * Updates docs * Minor doc changes * Remove cromwell_token * Pytests added for _create_cromwell_header function (#114) * Pytests added for _create_cromwell_header function * unused code removed * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * new folder for cloudos tests * init Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * test: add tests for 'get_job_list' (#116) * test: add tests for 'get_job_list' * refactor: add new assert statement * refactor: apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * style: move to proper folder * style: update tests/test_clos/test_get_job_list.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Fix: resolve JSON error in error message handling (#124) * fix error messages * Bump version to v1.3.1 * correct pytests using BadRequestException * Pytest for BadRequestException Class (#126) * pytest for BadRequestException * renamed function * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * requested changes * test moved to folder Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Pytest added for function project_id (#120) * pytest for function project_id * script updated * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * module docstring added * Update test_project_id.py * requested changes * Update tests/test_clos/test_project_id.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for function detect_workflow (#119) * proper json added * pytest function added * script updated for proper workflow name * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * import added * module docstring * Update tests/test_clos/test_detect_workflow.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * pytest added for output workflow_id (#121) * pytest added for output workflow_id * Object Class is modified to Job * values are masked * json update, assert update * module docstring added * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * requested changes Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest workflow (#132) * pytest added for output workflow_id * Object Class is modified to Job * values are masked * json update, assert update * module docstring added * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * requested changes Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for function process_workflow_list (#118) * Pytest for process_workflow_list added * file moved to test_clos folder * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * updated functions * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * code improvement * Update tests/test_clos/test_process_workflow_list.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Update tests/test_clos/test_process_workflow_list.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * test: adds tests for 'get_workflow_list' (#117) * test: add tests for 'get_workflow_list' method * refactor: apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * test: update bad request code and workflows .json * move test to proper folder * style: remove comment line * test: add workflows .json file Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for TimeOutException Class (#127) * pytest timeoutexception * descr update * Update test_timeout_exception.py * test moved to folder Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> * Pytest for send_job (#129) * Pytest for send_job * code improvment * update * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Pytest added for function get_cromwell_status (#123) * Pytest added for function get_cromwell_status * code layout fix * Update test_get_cromwell_status.py * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Pytest added for function ssl_selector (#122) * Pytest added for function ssl_selector * code improvements * test added for check ssl cert is a file * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * requested changes are made * blank Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest for cromwell_switch (#128) * Pytest for cromwell_switch * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for function get_job_status (#125) * pytest get_job_status * naming * out message fix * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * proper request json added * print removed * job status assertion update * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Fix: adapt to new projects api (#135) * fix the new api while maintaining backwards compatibility * update docs * update README.md date * remove cb (#136) * Fix: preparation for new `jobs` api endpoint spec (#138) * patch for the new api spec * update docs * update docs 2 * modify test data * fix test data * fix test data 2 --------- Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: Christina Chatzipantsiou <38183826+cgpu@users.noreply.github.com> Co-authored-by: egenc <erdal.genc09@gmail.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local>
dapineyro
added a commit
that referenced
this pull request
May 5, 2023
* feat: add `--request-interval` parameter (#93) * feat(parameters): add parameter for customization. See #90 * docs: add documentation in changelog and readme * bump: increse minor version 1.0.0 to 1.1.0 * refactor: replace command line option from cromwell with constant variable * docs: update about request interval option * refactor: add control expression to not surpass wait time * refactor: change variable to the constant for Cromwell jobs * Adds ssl verification control (#103) * Docs patch for SSL functionality (#106) * Update README.md Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Update README.md Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Change default cost limit 30 $ (#102) * Add new cost limit as default 30$ * CHANGELOG updated * VERSION updated * Update cloudos/__main__.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * version update * Update README.md * version bump to 1.2.1 Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Christina Chatzipantsiou <38183826+cgpu@users.noreply.github.com> Co-authored-by: dapineyro <dapineyro.dev@gmail.com> * Feat: make --wdl-importsFile optional (#98) * fix BadRequestException #84 * make wdl-importsfile optional * update docs * simplify code * simplify code 2 * simplify code 3 * simplify code 4 * small doc change * fix repo for projects * Update to prepare a release * Adds api key support for cromwell (#104) * fix BadRequestException #84 * make wdl-importsfile optional * update docs * simplify code * simplify code 2 * simplify code 3 * simplify code 4 * small doc change * fix repo for projects * Use API key when no cromwell key is available * Adds click support * small help change * Updates docs * Minor doc changes * Remove cromwell_token * Pytests added for _create_cromwell_header function (#114) * Pytests added for _create_cromwell_header function * unused code removed * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * new folder for cloudos tests * init Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * test: add tests for 'get_job_list' (#116) * test: add tests for 'get_job_list' * refactor: add new assert statement * refactor: apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * style: move to proper folder * style: update tests/test_clos/test_get_job_list.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Fix: resolve JSON error in error message handling (#124) * fix error messages * Bump version to v1.3.1 * correct pytests using BadRequestException * Pytest for BadRequestException Class (#126) * pytest for BadRequestException * renamed function * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * requested changes * test moved to folder Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Pytest added for function project_id (#120) * pytest for function project_id * script updated * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * module docstring added * Update test_project_id.py * requested changes * Update tests/test_clos/test_project_id.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for function detect_workflow (#119) * proper json added * pytest function added * script updated for proper workflow name * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * import added * module docstring * Update tests/test_clos/test_detect_workflow.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * pytest added for output workflow_id (#121) * pytest added for output workflow_id * Object Class is modified to Job * values are masked * json update, assert update * module docstring added * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * requested changes Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest workflow (#132) * pytest added for output workflow_id * Object Class is modified to Job * values are masked * json update, assert update * module docstring added * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * requested changes Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for function process_workflow_list (#118) * Pytest for process_workflow_list added * file moved to test_clos folder * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * updated functions * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * code improvement * Update tests/test_clos/test_process_workflow_list.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Update tests/test_clos/test_process_workflow_list.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * test: adds tests for 'get_workflow_list' (#117) * test: add tests for 'get_workflow_list' method * refactor: apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * test: update bad request code and workflows .json * move test to proper folder * style: remove comment line * test: add workflows .json file Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for TimeOutException Class (#127) * pytest timeoutexception * descr update * Update test_timeout_exception.py * test moved to folder Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> * Pytest for send_job (#129) * Pytest for send_job * code improvment * update * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Pytest added for function get_cromwell_status (#123) * Pytest added for function get_cromwell_status * code layout fix * Update test_get_cromwell_status.py * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Pytest added for function ssl_selector (#122) * Pytest added for function ssl_selector * code improvements * test added for check ssl cert is a file * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * requested changes are made * blank Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest for cromwell_switch (#128) * Pytest for cromwell_switch * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for function get_job_status (#125) * pytest get_job_status * naming * out message fix * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * proper request json added * print removed * job status assertion update * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Fix: adapt to new projects api (#135) * fix the new api while maintaining backwards compatibility * update docs * update README.md date * remove cb (#136) * Fix: preparation for new `jobs` api endpoint spec (#138) * patch for the new api spec * update docs * update docs 2 * modify test data * fix test data * fix test data 2 * Feat: adds ci tests (#142) * adding pytest * update setup * update setup 2 * update setup 3 * update setup 3 * adding job list * fix name * adds job run * adds job status * adds job status 2 * adds job status 2 * some debugging code * fix job status * adds workflow list * adding a job name * adding a job name 2 * point to staging * point to staging 2 * point to staging 3 * point to staging 4 * point to staging 5 * point to staging 6 * point to staging 7 * point to staging 8 * point to staging 9 * point to staging 10 * Feat: adds response pagination support for job list endpoint (#144) * implementing new feat * fix multiple spaces * typos * including review suggestions * fix pytests * Feat: adds commitizen (#145) * remove version from README.md * docs: add commitizen support * changelog * Feat: adds projects list (#146) * feat: add project list * bump: version 2.1.0 → 2.2.0 * update docs * add tests * adds ci test * update tests 2 * minor fixes * adapt to different responses * improve docstring * fix README.md * more docstring fixes * Feat: adds workflows --curated (#148) * first implementation + fix job list * adds parameters * fix pytests * remove curated-with-defaults * update docs * add ci test * small doc fixes * improve docstring * Feat: adds run-curated-examples command (#149) * first working prototype * implement first wait-completion * prettify the output * adding fixes * fix pytests * add new pytest * adding ci test * feat: add run-curated-examples command * bump: version 2.2.0 → 2.3.0 * updated changelog and version * README.md improvement * fixing pytest name * fix docstring typo * Feat: adds queue command (#151) * main.py CLI command implementation * first working implementation * fix api call * update docs * add pytests * feat: add queue list command * bump: version 2.3.0 → 2.4.0 * update changelog * update ci.yml * Feat: adds job queue support to batch runs (#152) * main.py CLI command implementation * first working implementation * fix api call * update docs * add pytests * feat: add queue list command * bump: version 2.3.0 → 2.4.0 * update changelog * update ci.yml * first implementation * improve messages * update pytest * fix pytest * update CI * update README.md * update README.md 2 * update README.md 3 * update README.md 4 * update README.md 5 * feat: adds job queue support to batch runs * bump: version 2.4.0 → 2.5.0 * update changelog * changing python requeriment to 3.7 * testing 3.7 with pytest --------- Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: Christina Chatzipantsiou <38183826+cgpu@users.noreply.github.com> Co-authored-by: egenc <erdal.genc09@gmail.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local>
dapineyro
added a commit
that referenced
this pull request
Jun 23, 2023
* feat: add `--request-interval` parameter (#93) * feat(parameters): add parameter for customization. See #90 * docs: add documentation in changelog and readme * bump: increse minor version 1.0.0 to 1.1.0 * refactor: replace command line option from cromwell with constant variable * docs: update about request interval option * refactor: add control expression to not surpass wait time * refactor: change variable to the constant for Cromwell jobs * Adds ssl verification control (#103) * Docs patch for SSL functionality (#106) * Update README.md Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Update README.md Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Change default cost limit 30 $ (#102) * Add new cost limit as default 30$ * CHANGELOG updated * VERSION updated * Update cloudos/__main__.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * version update * Update README.md * version bump to 1.2.1 Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Christina Chatzipantsiou <38183826+cgpu@users.noreply.github.com> Co-authored-by: dapineyro <dapineyro.dev@gmail.com> * Feat: make --wdl-importsFile optional (#98) * fix BadRequestException #84 * make wdl-importsfile optional * update docs * simplify code * simplify code 2 * simplify code 3 * simplify code 4 * small doc change * fix repo for projects * Update to prepare a release * Adds api key support for cromwell (#104) * fix BadRequestException #84 * make wdl-importsfile optional * update docs * simplify code * simplify code 2 * simplify code 3 * simplify code 4 * small doc change * fix repo for projects * Use API key when no cromwell key is available * Adds click support * small help change * Updates docs * Minor doc changes * Remove cromwell_token * Pytests added for _create_cromwell_header function (#114) * Pytests added for _create_cromwell_header function * unused code removed * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * new folder for cloudos tests * init Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * test: add tests for 'get_job_list' (#116) * test: add tests for 'get_job_list' * refactor: add new assert statement * refactor: apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * style: move to proper folder * style: update tests/test_clos/test_get_job_list.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Fix: resolve JSON error in error message handling (#124) * fix error messages * Bump version to v1.3.1 * correct pytests using BadRequestException * Pytest for BadRequestException Class (#126) * pytest for BadRequestException * renamed function * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * requested changes * test moved to folder Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Pytest added for function project_id (#120) * pytest for function project_id * script updated * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * module docstring added * Update test_project_id.py * requested changes * Update tests/test_clos/test_project_id.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for function detect_workflow (#119) * proper json added * pytest function added * script updated for proper workflow name * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * import added * module docstring * Update tests/test_clos/test_detect_workflow.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * pytest added for output workflow_id (#121) * pytest added for output workflow_id * Object Class is modified to Job * values are masked * json update, assert update * module docstring added * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * requested changes Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest workflow (#132) * pytest added for output workflow_id * Object Class is modified to Job * values are masked * json update, assert update * module docstring added * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * requested changes Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for function process_workflow_list (#118) * Pytest for process_workflow_list added * file moved to test_clos folder * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * updated functions * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * code improvement * Update tests/test_clos/test_process_workflow_list.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Update tests/test_clos/test_process_workflow_list.py Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * test: adds tests for 'get_workflow_list' (#117) * test: add tests for 'get_workflow_list' method * refactor: apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * test: update bad request code and workflows .json * move test to proper folder * style: remove comment line * test: add workflows .json file Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for TimeOutException Class (#127) * pytest timeoutexception * descr update * Update test_timeout_exception.py * test moved to folder Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> * Pytest for send_job (#129) * Pytest for send_job * code improvment * update * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Pytest added for function get_cromwell_status (#123) * Pytest added for function get_cromwell_status * code layout fix * Update test_get_cromwell_status.py * Apply suggestions from code review Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> * Pytest added for function ssl_selector (#122) * Pytest added for function ssl_selector * code improvements * test added for check ssl cert is a file * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * requested changes are made * blank Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest for cromwell_switch (#128) * Pytest for cromwell_switch * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Pytest added for function get_job_status (#125) * pytest get_job_status * naming * out message fix * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * proper request json added * print removed * job status assertion update * Apply suggestions from code review Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local> Co-authored-by: dapineyro <45285897+dapineyro@users.noreply.github.com> * Fix: adapt to new projects api (#135) * fix the new api while maintaining backwards compatibility * update docs * update README.md date * remove cb (#136) * Fix: preparation for new `jobs` api endpoint spec (#138) * patch for the new api spec * update docs * update docs 2 * modify test data * fix test data * fix test data 2 * Feat: adds ci tests (#142) * adding pytest * update setup * update setup 2 * update setup 3 * update setup 3 * adding job list * fix name * adds job run * adds job status * adds job status 2 * adds job status 2 * some debugging code * fix job status * adds workflow list * adding a job name * adding a job name 2 * point to staging * point to staging 2 * point to staging 3 * point to staging 4 * point to staging 5 * point to staging 6 * point to staging 7 * point to staging 8 * point to staging 9 * point to staging 10 * Feat: adds response pagination support for job list endpoint (#144) * implementing new feat * fix multiple spaces * typos * including review suggestions * fix pytests * Feat: adds commitizen (#145) * remove version from README.md * docs: add commitizen support * changelog * Feat: adds projects list (#146) * feat: add project list * bump: version 2.1.0 → 2.2.0 * update docs * add tests * adds ci test * update tests 2 * minor fixes * adapt to different responses * improve docstring * fix README.md * more docstring fixes * Feat: adds workflows --curated (#148) * first implementation + fix job list * adds parameters * fix pytests * remove curated-with-defaults * update docs * add ci test * small doc fixes * improve docstring * Feat: adds run-curated-examples command (#149) * first working prototype * implement first wait-completion * prettify the output * adding fixes * fix pytests * add new pytest * adding ci test * feat: add run-curated-examples command * bump: version 2.2.0 → 2.3.0 * updated changelog and version * README.md improvement * fixing pytest name * fix docstring typo * Feat: adds queue command (#151) * main.py CLI command implementation * first working implementation * fix api call * update docs * add pytests * feat: add queue list command * bump: version 2.3.0 → 2.4.0 * update changelog * update ci.yml * Feat: adds job queue support to batch runs (#152) * main.py CLI command implementation * first working implementation * fix api call * update docs * add pytests * feat: add queue list command * bump: version 2.3.0 → 2.4.0 * update changelog * update ci.yml * first implementation * improve messages * update pytest * fix pytest * update CI * update README.md * update README.md 2 * update README.md 3 * update README.md 4 * update README.md 5 * feat: adds job queue support to batch runs * bump: version 2.4.0 → 2.5.0 * update changelog * changing python requeriment to 3.7 * testing 3.7 with pytest * Feat: adds Azure support (#156) * add execution platform * add lacking parameter * adding default instance * correct pytest * bump version to 2.6.0 * update README.md * modify run-curated-examples * update docs * correcting ci url * deactivate spot and batch when using azure * fix last change --------- Co-authored-by: Daniel Boloc <danielboloc@users.noreply.github.com> Co-authored-by: Christina Chatzipantsiou <38183826+cgpu@users.noreply.github.com> Co-authored-by: egenc <erdal.genc09@gmail.com> Co-authored-by: Erdal Genc <erdalgenc@Erdals-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket
Purpose of this PR is to add tests for the function
Job.send_jobin CloudOS.Test data:
Tests are made for checking if the function
send_jobworking as intendedTo run the test:
Expected output:
