This repository was archived by the owner on Sep 30, 2020. It is now read-only.
feat: add no-arrow rule (#179) #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be applied selectively where we don't want arrow functions to break IE when we deliver untranspiled code. Not a breaking change because it isn't turned on by default. There are more sophisticated tools out there like: https://github.com/mysticatea/eslint-plugin-es Which have autofixes, but we want this to be a temporary measure anyway (the real fix is transpiling our themes JS) so let's not bring in another dependency. Closes: #179
|
Tested in liferay-portal: So seems fine to merge this. |
brianchandotcom
pushed a commit
to brianchandotcom/liferay-portal
that referenced
this pull request
May 7, 2020
Release notes:
https://github.com/liferay/liferay-npm-tools/releases/tag/liferay-npm-scripts%2Fv32.1.0
Brings in new eslint-config-liferay:
https://github.com/liferay/eslint-config-liferay/releases/tag/v21.1.0
And preset:
https://github.com/liferay/liferay-npm-tools/releases/tag/liferay-npm-bundler-preset-liferay-dev%2Fv4.3.1
In other words, a new "no-arrow" rule:
liferay/eslint-config-liferay#180
And a fix for this problem in the preset:
liferay/liferay-npm-tools#448
This commit includes fixes for the "no-arrow" rule violations in theme
JS files that don't (currently) go through the same kind of build
transpilation pipeline that our other JS does. This fixes breakage in
IE.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be applied selectively where we don't want arrow functions to break IE when we deliver untranspiled code.
Not a breaking change because it isn't turned on by default.
There are more sophisticated tools out there like:
https://github.com/mysticatea/eslint-plugin-es
Which have autofixes, but we want this to be a temporary measure anyway (the real fix is transpiling our themes JS) so let's not bring in another dependency.
Closes: #179