LPD-67725 Hotfixes not downloaded from GCP buckets

[drewbrokke]

This is an update for LPD-67725.

[drewbrokke]

FYI @holatuwol

[holatuwol]

releases-cdn.liferay.com

I tested with these properties:

lr.docker.environment.service.enabled[postgres]=true
lr.docker.environment.database.partitioning.enabled=true
liferay.workspace.product=dxp-2025.q2.1
liferay.workspace.docker.image.liferay=liferay/dxp:2025.q2.1-d9.0.30-20250912074320
lr.docker.environment.hotfix.urls=https://releases-cdn.liferay.com/dxp/hotfix/2025.q2.1/liferay-dxp-2025.q2.1-hotfix-34.zip
lr.docker.environment.lxc.environment.name=x1e4prd3

Then ran into the following error:

* What went wrong:
Execution failed for task ':prepareHotfixes'.
> Duplicate destination file '/home/me/dev/workspace/lec-x1e4prd3/configs/common/patching/liferay-dxp-2025.q2.1-hotfix-34.zip'

storage.cloud.liferay.com

I attempted to manually set lr.docker.environment.hotfix.urls to use a storage.cloud.google.com URL

lr.docker.environment.service.enabled[postgres]=true
lr.docker.environment.database.partitioning.enabled=true
liferay.workspace.product=dxp-2025.q2.1
liferay.workspace.docker.image.liferay=liferay/dxp:2025.q2.1-d9.0.30-20250912074320
lr.docker.environment.hotfix.urls=https://storage.cloud.google.com/liferay-releases-hotfix/2025.q2.1/liferay-dxp-2025.q2.1-hotfix-34.zip
lr.docker.environment.lxc.environment.name=x1e4prd3

However, updateDatabaseForLocalDevelopment copies the original configuration again, causing it to reuse the old value, which re-introduces the issue.

Fixing the issue

I updated the function updateDatabaseForLocalDevelopment so that it doesn't call copyLiferayLXCRepositoryConfigurations and that strangely resolved the issue for both values of lr.docker.environment.hotfix.urls

Now that we have the lec init option, that function is redundant and may do the wrong thing, so we should remove it.