feat: support internal path exports in npm-scripts #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that we only support .css and .js exports for now. In the future we may want to support .json, .svg, or other static resources we see fit. This is part of [https://issues.liferay.com/browse/LPS-172747](LPS-172747). ---- ⚠ WARNING !!! This implementation is missing a corner use case: an AMD module that wants to use an internal path export ending in .js. We won't support that case unless it is absolutely necessary, since it can be fixed migrating the offending project from AMD to ESM. ----
projects/npm-tools/packages/npm-scripts/src/utils/createEsm2AmdExportsBridges.js
Show resolved
Hide resolved
Member
Author
|
Windows test failing once again 😮 How come? 🙄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.liferay.com/browse/LPS-172747