Skip to content

Conversation

@wincent
Copy link
Contributor

@wincent wincent commented Oct 13, 2020

Step 3 of 5.

Previously:

  1. chore(js-toolkit): move liferay-js-toolkit-core (v3.x) to @liferay/js-toolkit-core #150 (js-toolkit-core)
  2. chore(js-toolkit): move generator-liferay-js (v3.x) to @liferay/generator-js #151 (generator-js)

A draft because it depends on the previous ones and they need to go in first.

@wincent
Copy link
Contributor Author

wincent commented Oct 14, 2020

Going to rebase this one too now.

@wincent wincent marked this pull request as ready for review October 14, 2020 09:29
@wincent wincent force-pushed the wincent/scope/js-toolkit-scripts branch from 2af36fb to dab4f55 Compare October 14, 2020 09:32
@wincent
Copy link
Contributor Author

wincent commented Oct 14, 2020

Same as #151 — going to merge and test to confirm that the release process works (will be a prerelease), even though this package has effectively never been published before (and may never be published again, as it will apparently be subsumed into the bundler itself — even so, I want everything that's under packages/ to be consistent).

@wincent wincent merged commit 052f6cb into master Oct 14, 2020
@wincent wincent deleted the wincent/scope/js-toolkit-scripts branch October 14, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants