Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/js-toolkit/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ yarn ci
# start again. Otherwise...

# Change to the directory of the package you wish to publish:
cd packages/liferay-npm-bundler
cd packages/npm-bundler

# Update the changelog:
npx @liferay/changelog-generator --version=3.0.0
Expand All @@ -143,7 +143,7 @@ Copy the relevant section from the changelog to the corresponding entry on the [
After the release, you can confirm that the packages are correctly listed in the NPM registry:

- https://www.npmjs.com/package/@liferay/js-toolkit-core
- https://www.npmjs.com/package/liferay-npm-bundler
- https://www.npmjs.com/package/@liferay/npm-bundler

## Releasing pre-release versions

Expand Down
4 changes: 2 additions & 2 deletions projects/js-toolkit/packages/generator-js/src/adapt/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,8 @@ export default class extends Generator {
getSDKVersion('liferay-npm-build-support', {ignoreConfig: true})
);
pkgJson.addDevDependency(
'liferay-npm-bundler',
getSDKVersion('liferay-npm-bundler', {ignoreConfig: true})
'@liferay/npm-bundler',
getSDKVersion('@liferay/npm-bundler', {ignoreConfig: true})
);
pkgJson.addDevDependency(
`liferay-npm-bundler-preset-${preset}`,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ export default class extends Generator {
const cp = new Copier(this);

const context = {
liferayNpmBuildSupportVersion: getSDKVersion('liferay-npm-bundler'),
liferayNpmBuildSupportVersion: getSDKVersion(
'@liferay/npm-bundler'
),
liferayNpmBundlerVersion: getSDKVersion(
'liferay-npm-build-support'
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"description": "<%= description %>",
"devDependencies": {
"liferay-npm-bundler": "<%= liferayNpmBundlerVersion %>",
"@liferay/npm-bundler": "<%= liferayNpmBundlerVersion %>",
"liferay-npm-build-support": "<%= liferayNpmBuildSupportVersion %>"
},
"dependencies": {},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ export default class Probe {
return ProjectType.LIFERAY_FRAGMENT;
}

// This must go last, as all other types have liferay-npm-bundler as
// dependency
// This must go last, as all other types have (or may have)
// @liferay/npm-bundler as dependency.

if (
this._hasDependency('liferay-npm-bundler') ||
this._hasDependency('@liferay/npm-bundler') ||
this._hasDependency('@liferay/js-toolkit-scripts') ||
this._hasScriptCalling('js-toolkit')
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ export default class Project {

// Get bundler and me versions

putInMap('liferay-npm-bundler');
putInMap('@liferay/npm-bundler');
putInMap(path.join(__dirname, '../..'));

// Get preset version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -372,9 +372,9 @@ describe('project.versionsInfo', () => {
},
],
[
'liferay-npm-bundler',
'@liferay/npm-bundler',
{
version: require(`../../../../../../../node_modules/liferay-npm-bundler/package.json`)
version: require(`../../../../../../../node_modules/@liferay/npm-bundler/package.json`)
.version,
path: path.join(
'..',
Expand All @@ -388,7 +388,8 @@ describe('project.versionsInfo', () => {
'..',
'..',
'node_modules',
'liferay-npm-bundler'
'@liferay',
'npm-bundler'
),
},
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ function addLocalizationFiles(zip: JSZip): void {
function addManifest(zip: JSZip): void {
let contents = '';

const bundlerVersion = project.versionsInfo.get('liferay-npm-bundler')
const bundlerVersion = project.versionsInfo.get('@liferay/npm-bundler')
.version;

contents += `Manifest-Version: 1.0\n`;
Expand Down
3 changes: 0 additions & 3 deletions projects/js-toolkit/packages/liferay-npm-bundler/.yarnrc

This file was deleted.

3 changes: 3 additions & 0 deletions projects/js-toolkit/packages/npm-bundler/.yarnrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Make `yarn version` produce the right commit message and tag for this package.
version-tag-prefix "npm-bundler/v"
version-git-message "chore: prepare @liferay/npm-bundler v%s release"
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# liferay-npm-bundler
# @liferay/npm-bundler

A tool to process a Liferay widget project to produce an OSGi bundle containing the needed npm dependencies so that it can be run when deployed to the Portal.
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
"description": "A CLI utility to bundle NPM dependencies of a Liferay OSGi bundle.",
"license": "LGPL-3.0",
"main": "lib/index.js",
"name": "liferay-npm-bundler",
"name": "@liferay/npm-bundler",
"repository": {
"directory": "projects/js-toolkit/packages/liferay-npm-bundler",
"directory": "projects/js-toolkit/packages/npm-bundler",
"type": "git",
"url": "https://github.com/liferay/liferay-frontend-projects.git"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import report from './report';
import abort from './util/abort';
import * as log from './util/log';

/** Default entry point for the liferay-npm-bundler */
/** Default entry point for the liferay-npm-bundler executable. */
export default async function (argv: {version: boolean}): Promise<void> {
if (argv.version) {
const {versionsInfo} = project;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
]
},
"devDependencies": {
"@liferay/npm-bundler": "^3.0.0",
"liferay-npm-build-support": "^3.0.0",
"liferay-npm-bundler": "^3.0.0",
"liferay-npm-bundler-preset-create-react-app": "^3.0.0"
},
"portlet": {
Expand Down
3 changes: 2 additions & 1 deletion projects/js-toolkit/scripts/qa/resources.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ const {version: currentSDKVersion} = require(path.join(
'..',
'..',
'packages',
'liferay-npm-bundler',
'@liferay',
'npm-bundler',
'package.json'
));

Expand Down