fix(js-toolkit): fix various integration problems with DXP #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had inconsistent coverage here, which meant that our recent
`@liferay/npm-bundler` release was missing some files. We need
"prepublishOnly" to ensure "build" runs before "publish", because we use
"copyfiles" to copy things like these templates from "src" to "lib":
src/adapt/templates
├── export-module.ejs
├── index.js.ejs
└── manifest-module.ejs
This was manifesting as described here:
liferay-frontend/liferay-portal#429 (comment)
with:
Error: ENOENT: no such file or directory, open
'modules/node_modules/@liferay/npm-bundler/lib/adapt/templates/export-module.ejs'
Before this commit we had a variety of set-ups on the js-toolkit
packages:
- generator-js: had "prepublish", which did a build during install as
well (not what we want, because it generates noise on the `yarn
install`; everything that gets installed from the npm registry should
already be complete and ready to go).
- js-toolkit-core: no "prepublish" or "prepublishOnly", which runs the
risk of making a build without all the necessary files.
- js-toolkit-scripts: "prepublish" instead of "prepublishOnly".
- npm-bridge-generator: same.
- npm-bundler: like js-toolkit-core, no "prepublish" or
"prepublishOnly".
We were producing bad paths like:
.//Users/greghurrell/code/portal/liferay-portal/modules/apps/frontend-js/frontend-js-recharts/build/node/bundler/bundler/generated/recharts.js
leading to errors:
❌ EntryModuleNotFoundError: Entry module not found: Error: Can't resolve '...'
as described here:
liferay-frontend/liferay-portal#429 (comment)
We shouldn't be prepending `./` here, because the `generatedFile` is a
`FilePath` object and it appears that it is always absolute.
As described here: - liferay-frontend/liferay-portal#429 (comment) - liferay/liferay-js-toolkit@a931aed#r43235455 our configs use a workdir of `build/node/bundler`, which means that appending another `bundler` produces undesired nesting.
Contributor
Author
|
I got a preapproved credit line to merge this (via @izaera from Slack, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues discovered in liferay-frontend/liferay-portal#429
See individual commit messages for explanations.