Skip to content

Conversation

@wincent
Copy link
Contributor

@wincent wincent commented Feb 3, 2021

Based on conversation here which was about not finding contributing guidelines for how to format commit messages.

We could still use some more specific docs about what scopes we'd like to see when working in the monorepo (eg. using scopes to indicate project), so I added that in the second commit.

Based on conversation here:

    #389 (comment)

which was about not finding contributing guidelines for how to format
commit messages.

We could still use some more specific docs about what scopes we'd like
to see when working in the monorepo (eg. using scopes to indicate
project), so I'll put that in the next commit.
@wincent
Copy link
Contributor Author

wincent commented Feb 3, 2021

@kresimir-coko: in an ideal world, we'd mention the scope in every single project-specific CONTRIBUTING.md, but I am too lazy for that (when we moved projects into the monorepo, each project came in with its own CONTRIBUTING.md and we only lightly edited it to reflect the new reality... updating paths and such).

And note that I didn't include a scope in this PR because it isn't specific to any project, and it isn't what I'd call "cross-cutting" either (ie. touching multiple projects). It's just a tiny doc tweak, and it doesn't touch any paths that would cause it to show up in project-specific changelogs, so it doesn't need a scope.

@kresimir-coko
Copy link
Member

@wincent Awesome! One more thing I noticed right now, in the Liferay Frontend Guidelines, the first 2 links (bolded) are pointing to a 404:

This is a live (changing) repository containing general and Liferay DXP-specific guidelines for doing Frontend Development at Liferay Inc.

@wincent
Copy link
Contributor Author

wincent commented Feb 5, 2021

Thanks for catching the 404s! Will update.

@wincent wincent merged commit fde79d8 into master Feb 5, 2021
@wincent wincent deleted the wincent/link-to-guidelines-from-contributing branch February 5, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants