Skip to content

feat(eslint-plugin): add new rule to disallow 'use strict' in es modules #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

feat(eslint-plugin): add new rule to disallow 'use strict' in es modules #710

wants to merge 3 commits into from

Conversation

@bryceosterhaus
Copy link
Member

@bryceosterhaus bryceosterhaus commented Oct 21, 2021 •
edited
Loading

fixes #20
fixes #25

@bryceosterhaus
Copy link
Member Author

bryceosterhaus commented Oct 21, 2021

DXP:
@liferay/no-anonymous-exports: 615 errors 😨 (might need to add an autofix or use codemod to update dxp)
@liferay/no-use-strict-in-module: 43 errors

@bryceosterhaus
Copy link
Member Author

bryceosterhaus commented Oct 21, 2021

i don't know why you are failing format...

@bryceosterhaus
Copy link
Member Author

bryceosterhaus commented Oct 21, 2021

maybe a new pr?

@bryceosterhaus
Copy link
Member Author

bryceosterhaus commented Oct 21, 2021

new pr

Screen Shot 2021-10-21 at 3 14 22 PM

@bryceosterhaus bryceosterhaus deleted the 20 branch October 25, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3.x docs eslint-plugin js-toolkit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Force consistent style for function exports Get rid of redundant "use strict" in ES modules

1 participant

@bryceosterhaus