feat: support Solana standard orders by Asem-Abdelhady · Pull Request #3 · lifinance/intent.ts

Asem-Abdelhady · 2026-03-09T21:46:25Z

Summary

Adds StandardSolana order type — a single-input variant of StandardOrder for Solana input settlers
Adds Borsh serialization (borshEncodeSolanaOrder) and order ID derivation (computeStandardSolanaId) matching the common::types::StandardOrder layout in catalyst-intent-svm
Routes EVM→Solana output tokens to the correct output settler PDA in buildMandateOutputs, falling back to COIN_FILLER for EVM outputs
Adds outputRecipient option to CreateIntentOptions to support a different recipient than the connected wallet
Extends CoreToken with chainNameSpace: "eip155" | "solana" (CAIP namespace) for output routing

Design notes

StandardSolana enforces a single input — the Solana program only supports one SPL token input per order. standardOrderToSolanaOrder throws if called with zero or more than one input.
Input amount is encoded as u64 (Solana stores SPL amounts as u64); output amount is bytes32 to match the EVM ABI layout.
Mainnet and testnet settler addresses are undefined with TODO comments — inputSettlerForSolana and buildMandateOutputs throw for undeployed chains.

Testing

src/intent/solanaStandard.spec.ts — full coverage: Borsh encoding golden value, u32 overflow guards, mutation tests, conversion helpers, StandardSolanaIntent class
src/intent/helpers/output-encoding.spec.ts — Solana PDA routing, unsupported chain rejection, EVM regression coverage
src/intent/helpers/shared.spec.ts — inputSettlerForSolana happy path and error paths
Run all tests: bun test

reednaa

A few nits. Ideally we simplify the library rather than add to it.

reednaa

The added files does not have test coverage unlike all other files in this repository.

Provide coverage of solanaStandard.spec.ts.

Here are a variety of agent findings:

src/intent/solanaStandard.ts

The amount field in mandateInputSchema uses "u64" but borshEncodeSolanaOrder passes BigInt(order.input.amount) — this is fine for
u64, but the amount in mandateOutputSchema uses bytes32 (big-endian 32-byte encoding), which is inconsistent. Verify this matches
the SVM program's actual layout.
The standardOrderToSolanaOrder conversion only uses the first input (order.inputs[0]), silently dropping all others. A
StandardOrder can have multiple inputs — should this throw if inputs.length > 1 rather than silently truncating?
borshEncodeSolanaOrder is exported but not re-exported from src/intent/index.ts. Intentional or oversight?

src/intent/helpers/output-encoding.ts

outputSettler is now computed per-output via getSettler?.(token.chainId) ?? COIN_FILLER — this is a meaningful behavioral change
for all EVM orders too (previously settled globally). Ensure no regression for existing EVM paths.

src/helpers/convert.ts

The early-return guard for already-bytes32 addresses is reasonable, but a Solana address (base58 string) would fail silently or
produce wrong output if passed here. The comment says "Accept only EVM addresses here" but there's no enforcement — could confuse
callers

reednaa · 2026-03-13T11:31:12Z


 export function addressToBytes32(address: `0x${string}`): `0x${string}` {
+  if (address.length === 66) return address; // already bytes32 with 0x prefix
+  if (address.length === 64) return `0x${address}`; // already bytes32 without 0x


Does this properly catch 64 length addresses prefixed with 0x?

I would rather use something like: 0x${address.replace("0x", "").padStart("0", 64)}

yeah i think we should remove if (address.length === 64) also we don't need to check the address length in address.length !== 40 for EVM since we are already constraining the template with address: 0x${string} in the parameters.

reednaa · 2026-03-13T11:37:53Z

  asOrder(): TOrder;
  inputChains(): bigint[];
  orderId(): `0x${string}`;
-  compactClaimHash(): `0x${string}`;


This is required. Add a handler for EVM vs Solana and then provide compactClaimHash if chain is identified as EVM.

The PR accidentally swapped compact↔escrow settler assignments. Restores the original: compact/single→COMPACT_LIFI, compact/multi→MULTICHAIN_COMPACT, escrow/single→ESCROW_LIFI, escrow/multi→MULTICHAIN_ESCROW. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

reednaa · 2026-04-02T07:42:53Z

+export const SOLANA_MAINNET_CHAIN_ID = 1151111081099710n;
+export const SOLANA_TESTNET_CHAIN_ID = 1151111081099711n;
+export const SOLANA_DEVNET_CHAIN_ID = 1151111081099712n;


Do we want to consider renaming these to just SOLANA_MAINNET, SOLANA_TESTNET, etc?

reednaa · 2026-04-06T11:09:23Z

+export type StandardSolana = {
+  user: `0x${string}`;
+  nonce: bigint;
+  originChainId: bigint;


Suggested change

originChainId: bigint;

originChainId: SOLANA_MAINNET_CHAIN_ID I SOLANA_TESTNET_CHAIN_ID | SOLANA_DEVNET_CHAIN_ID;

reednaa · 2026-04-06T11:12:33Z

  inputSettler: `0x${string}`;
-  private readonly order: StandardOrder;
+  private readonly order: StandardEVM;



chainNamespace: ""

reednaa · 2026-04-06T11:13:23Z


  orderId(): `0x${string}` {
-    return computeStandardOrderId(this.inputSettler, this.order);
+    return computeStandardEVMId(this.inputSettler, this.order);


reednaa · 2026-04-06T11:13:42Z

@@ -60,7 +60,7 @@ export class StandardOrderIntent implements OrderIntentCommon<StandardOrder> {
  }

  orderId(): `0x${string}` {


if (namespace == "EIP155") EVMIntent.orderId()...
if (namespace == "solana") SolanaIntent.orderId()

reednaa · 2026-04-06T11:19:33Z

+    return computeStandardEVMId(this.inputSettler, this.order);
  }

  compactClaimHash(): `0x${string}` {


Suggested change

compactClaimHash(): `0x${string}` {

compactClaimHash(this: StandardOrder<"EIP155">): `0x${string}` {

Asem-Abdelhady · 2026-04-06T12:20:59Z

After discussing it with @reednaa this PR will be merged to finalise lintent.org.
New branch should be made to do changes of:

1- Remove: CHAIN_ID from solana chain ids constants names.
2- Change the standard orders and intents strutucure to be generic bounded structure with namespace instead of making it separate interfaces.
3- Rename/fix: functions names to reflect the new changes.

Asem-Abdelhady added 6 commits March 9, 2026 14:30

feat: support solana

348160b

chore: extra guards for address32bytes

73741b7

chore: clean changes

9ef3a04

chore: clean changes

14445f4

feat: cover solana order id

2f75746

chore: revert unnecessary changes

f7e0d0b

Asem-Abdelhady requested a review from reednaa March 9, 2026 21:55

reednaa requested changes Mar 10, 2026

View reviewed changes

Comment thread src/deps.ts Outdated

Comment thread src/types/solana.ts Outdated

Comment thread src/intent/solana.ts Outdated

reednaa requested changes Mar 10, 2026

View reviewed changes

Comment thread src/deps.ts Outdated

Comment thread src/deps.ts Outdated

Comment thread src/deps.ts Outdated

chore: Add solana to the smae structure

33b239e

Asem-Abdelhady requested a review from reednaa March 11, 2026 10:17

reednaa requested changes Mar 13, 2026

View reviewed changes

Asem-Abdelhady and others added 7 commits March 16, 2026 21:58

chore: clean up code

bad6d73

remove: unnecessary changes

6bcc581

remove: unnecessary changes

0c336aa

remove: unnecessary comments

52f38b2

remove: unnecessary changes

59d3397

remove: unnecessary changes

f04f8e4

Asem-Abdelhady requested a review from reednaa April 1, 2026 12:57

reednaa requested changes Apr 2, 2026

View reviewed changes

Asem-Abdelhady changed the title ~~Asem/v2 109/solana orders~~ feat: support Solana standard orders Apr 2, 2026

Asem-Abdelhady added 2 commits April 2, 2026 16:40

fix: address PR review feedback

3b0127e

chore: renaming && remove unused mandate input type

c6b3b24

Asem-Abdelhady requested a review from reednaa April 3, 2026 11:56

reednaa requested changes Apr 6, 2026

View reviewed changes

reednaa approved these changes Apr 6, 2026

View reviewed changes

Asem-Abdelhady merged commit aab6585 into main Apr 6, 2026
1 check passed

	originChainId: bigint;
	originChainId: SOLANA_MAINNET_CHAIN_ID I SOLANA_TESTNET_CHAIN_ID \| SOLANA_DEVNET_CHAIN_ID;

		@@ -60,7 +60,7 @@ export class StandardOrderIntent implements OrderIntentCommon<StandardOrder> {
		}

		orderId(): `0x${string}` {

	compactClaimHash(): `0x${string}` {
	compactClaimHash(this: StandardOrder<"EIP155">): `0x${string}` {

Conversation

Asem-Abdelhady commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Design notes

Testing

Uh oh!

reednaa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reednaa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Asem-Abdelhady Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Asem-Abdelhady commented Apr 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Asem-Abdelhady commented Mar 9, 2026 •

edited

Loading

Asem-Abdelhady Mar 13, 2026 •

edited

Loading