fix(wallet-management): fix leather wallet reconnect issue#579
Closed
tomiiide wants to merge 5 commits into
Closed
fix(wallet-management): fix leather wallet reconnect issue#579tomiiide wants to merge 5 commits into
tomiiide wants to merge 5 commits into
Conversation
|
Hey! This is your new endpoint: https://17e4989d.widget-lf16080fix.pages.dev |
|
Hey! This is your new endpoint: https://016fd72e.widget-lf16080fix.pages.dev |
|
Hey! This is your new endpoint: https://3d2ad06c.widget-lf16080fix.pages.dev |
|
Hey! This is your new endpoint: https://9008d44f.widget-lf16080fix.pages.dev |
tomiiide
changed the title
|
Hey! This is your new endpoint: https://468d0f43.widget-lf16080fix.pages.dev |
Member
|
Closing this and updating the packages in a separate commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira task is linked to this PR?
https://lifi.atlassian.net/browse/LF-16080
Why was it implemented this way?
The problem
Leather wallet does not persist dapp connections. While the connector saves connection state locally and attempts to reconnect via
getAddresses()on refresh, the wallet itself is unaware of any previous connection and treats each call as a new connection request, resulting in a repeated popup for every page refresh.https://leather.gitbook.io/developers/methods/getaddresses#sandbox
The solution
Disable this behavior.
Visual showcase (Screenshots or Videos)
Checklist before requesting a review