Conversation
|
Hey! This is your new endpoint: https://ecb7ded9.widget-featsendto.pages.dev |
|
Hey! This is your new endpoint: https://b4cbeb46.widget-featsendto.pages.dev |
|
Hey! This is your new endpoint: https://a17947cd.widget-featsendto.pages.dev |
|
Hey! This is your new endpoint: https://8f5dae66.widget-featsendto.pages.dev |
|
Hey! This is your new endpoint: https://c3158a28.widget-featsendto.pages.dev |
|
Hey! This is your new endpoint: https://3e9be4a0.widget-featsendto.pages.dev |
|
Hey! This is your new endpoint: https://52cd6ad5.widget-featsendto.pages.dev |
|
Hey! This is your new endpoint: https://900010ea.widget-featsendto.pages.dev |
|
Hey! This is your new endpoint: https://a8f0e15b.widget-featsendto.pages.dev |
|
Hey! This is your new endpoint: https://66c90d46.widget-featsendto.pages.dev |
|
Hey! This is your new endpoint: https://1d156e0a.widget-featsendto.pages.dev |
|
Hey! This is your new endpoint: https://bcfba1f5.widget-featsendto.pages.dev |
| @@ -1,14 +1,12 @@ | |||
| import ArrowDownward from '@mui/icons-material/ArrowDownward' | |||
| import ArrowForward from '@mui/icons-material/ArrowForward' | |||
| import type { JSX } from 'react' | |||
There was a problem hiding this comment.
some components keep React.FC, this one removes it. Is this a convention?
There was a problem hiding this comment.
It's mixed currently, should not be a blocker.
| setSendToWallet(address) | ||
| } | ||
|
|
||
| // we can assume that the toAddress has been passed as ToAddress object |
There was a problem hiding this comment.
check if this is important context to keep
There was a problem hiding this comment.
yes, reverted, let's keep it
|
Hey! This is your new endpoint: https://22b9478c.widget-featsendto.pages.dev |
3 participants
Which Linear task is linked to this PR?
https://linear.app/lifi-linear/issue/EMB-319/replace-send-to-wallet-input-with-inline-send-to-wallet-button
Why was it implemented this way?
The behaviour of
SendToWalletExpandButtonchanges: it is not a toggle anymore. The button is visible only when wallet address is not optional and not set and leads to "Send to wallet" page instead of opening "Send to wallet" input card.Adds "Required" tag to the "Send to wallet" input card.
useSendToWalletStoreis removed: the visibility of the "Send to wallet" input card is determined from the availability of wallet address and whether it is required or not.Visual showcase (Screenshots or Videos)
Screen.Recording.2026-04-01.at.12.48.12.mov
Checklist before requesting a review