feat(widget)!: remove deprecated _vcComponent from WidgetFeeConfig#742
Merged
Conversation
E2E Examples — failuresThe following example(s) failed:
See the workflow run for Playwright reports and logs. |
chybisov
changed the title
The internal _vcComponent field on WidgetFeeConfig is no longer needed. Removes the field, the rendering branch in StatusBottomSheet, and the related comment in widget-light's mirror. Refs EMB-389
chybisov
force-pushed
the
feature/emb-389-config-remove-vc-component
branch
from
9ab65a9 to
d8776aa
Compare
chybisov
changed the title
effie-ms
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
EMB-389 — Wave 1, item #5
Why was it implemented this way?
WidgetFeeConfig._vcComponentwas marked@internalbut still appeared in generated.d.tsfiles and IntelliSense — and is no longer needed. This PR deletes the field and its rendering branch inStatusBottomSheet.tsxentirely. No replacement.Why a clean delete (not a deprecate-then-remove cycle): the field was prefixed with
_and marked@internal, so no external integrator should have a legitimate dependency on it. v4 is the right window to remove leaked internals before they ossify.Migration
If you were depending on the internal
_vcComponentfield onWidgetFeeConfig(prefixed with_and marked@internal), it has been removed with no replacement. Remove anyfeeConfig._vcComponentreferences from your config.Visual showcase
N/A — removing an unused render branch. Smoke test confirms the transaction success state renders with the correct margin (was conditionally 2 or 3, now unconditionally 3 — the pre-_vcComponent default).
Checklist before requesting a review