feat(widget)!: rename useRecommendedRoute to showSingleRoute#743
Merged
Conversation
E2E Examples — failuresThe following example(s) failed:
See the workflow run for Playwright reports and logs. |
chybisov
changed the title
The flag controls whether the widget shows only the recommended route and hides the route selector — not the route priority order. Rename makes the semantics clearer. Refs EMB-389
chybisov
force-pushed
the
feature/emb-389-config-rename-show-single-route
branch
from
38ebee1 to
4185abe
Compare
effie-ms
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
EMB-389 — Wave 1, item #6
Why was it implemented this way?
useRecommendedRouteis a boolean toggle that hides the route selector and shows only one route. The name implies it controls route priority (which is actually whatroutePrioritydoes), but its effect is to collapse the UI to a single route view.Verified the two semantics are distinct:
routePriority→ which route to rank first (passed to the SDK).useRecommendedRoute/showSingleRoute→ whether to hide the route selector and show only the recommended one (Routes.tsx:42,useWideVariant.ts:12).showSingleRoutematches the actual effect.Alternatives considered:
hideRouteSelector— describes the consequence, not the intent.disableRouteSelection— implies the selector is interactive but disabled, which is misleading.singleRoute: boolean— terser but loses the verb that hints at the UI behavior.Visual showcase
N/A — pure rename. Smoke test confirms the playground loads with widget mounted.
Checklist before requesting a review
Breaking change
Migration:
```diff
```