Skip to content

fix: unify empty state components and fix wallet list scroll behavior#746

Merged
chybisov merged 6 commits into
mainfrom
fix/wallets-bookmarks-selectors
May 28, 2026
Merged

fix: unify empty state components and fix wallet list scroll behavior#746
chybisov merged 6 commits into
mainfrom
fix/wallets-bookmarks-selectors

Conversation

@effie-ms
Copy link
Copy Markdown
Contributor

@effie-ms effie-ms commented May 25, 2026

Which Linear task is linked to this PR?

https://linear.app/lifi-linear/issue/EMB-391/unify-empty-state-components-and-fix-wallet-list-scroll-behavior

Why was it implemented this way?

The wallet/bookmark selector pages had 3 issues: inconsistent empty state styling, whole-widget scrolling instead of list-only scrolling and non-unique icon for "Recent wallets".

  • Created a shared EmptyListIndicator component (components/EmptyListIndicator/) with icon, title, and optional message — matching the activities page pattern. This replaces the old EmptyListIndicator (children-based, no description text) and the inline TransactionHistoryEmpty implementation.
  • Added useListHeight to BookmarksPage, RecentWalletsPage, and ConnectedWalletsPage so the list area scrolls internally rather than the entire widget.
  • Updated BookmarksListContainer to use flex-based layout (flex: 1; minHeight: 0; overflow: auto) instead of hardcoded min-heights, so the button stays pinned and the list fills available space.
  • Added description messages for all three wallet empty states and updated the transaction history empty message to be action-oriented.
  • Replaced the History icon with AccountBalanceWalletIcon for the recent wallets button and empty state.
Screen.Recording.2026-05-26.at.16.32.41.mov

Configured wallets (when setting toAddresses):
Screenshot 2026-05-26 at 16 42 12
https://github.com/user-attachments/assets/4db77c7c-2451-4c52-89d8-89de69832928

Full height:
https://github.com/user-attachments/assets/36ed76e4-1299-4384-ad3f-bebed54dce19

Checklist before requesting a review

  • I have performed a self-review and testing of my code.
  • This pull request is focused and addresses a single problem.

@effie-ms effie-ms marked this pull request as draft May 25, 2026 16:44
@effie-ms effie-ms self-assigned this May 25, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 25, 2026

E2E Examples — failures

The following example(s) failed:

  • nft-checkout
  • vite-iframe-wagmi

See the workflow run for Playwright reports and logs.

@effie-ms effie-ms marked this pull request as ready for review May 26, 2026 14:47
@effie-ms effie-ms requested a review from chybisov May 26, 2026 14:47
@chybisov chybisov merged commit c2868e5 into main May 28, 2026
15 of 21 checks passed
@chybisov chybisov deleted the fix/wallets-bookmarks-selectors branch May 28, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants