fix: unify empty state components and fix wallet list scroll behavior#746
Merged
Conversation
E2E Examples — failuresThe following example(s) failed:
See the workflow run for Playwright reports and logs. |
2 tasks
…nents in SendToWallet pages
…t path for ListItemButton
2 tasks
chybisov
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
https://linear.app/lifi-linear/issue/EMB-391/unify-empty-state-components-and-fix-wallet-list-scroll-behavior
Why was it implemented this way?
The wallet/bookmark selector pages had 3 issues: inconsistent empty state styling, whole-widget scrolling instead of list-only scrolling and non-unique icon for "Recent wallets".
EmptyListIndicatorcomponent (components/EmptyListIndicator/) with icon, title, and optional message — matching the activities page pattern. This replaces the oldEmptyListIndicator(children-based, no description text) and the inlineTransactionHistoryEmptyimplementation.useListHeighttoBookmarksPage,RecentWalletsPage, andConnectedWalletsPageso the list area scrolls internally rather than the entire widget.BookmarksListContainerto use flex-based layout (flex: 1; minHeight: 0; overflow: auto) instead of hardcoded min-heights, so the button stays pinned and the list fills available space.Historyicon withAccountBalanceWalletIconfor the recent wallets button and empty state.Screen.Recording.2026-05-26.at.16.32.41.mov
Configured wallets (when setting

toAddresses):https://github.com/user-attachments/assets/4db77c7c-2451-4c52-89d8-89de69832928
Full height:
https://github.com/user-attachments/assets/36ed76e4-1299-4384-ad3f-bebed54dce19
Checklist before requesting a review