fix(widget): add Lighter explorer path override for address links#747
Merged
Merged
Conversation
Lighter's explorer doesn't support /address/<wallet>, only /explorer/logs/<hash> and /explorer/accounts/<index>. Add ChainId.LTR override so address and transaction links no longer 404. Resolves EMB-395
E2E Examples — failuresThe following example(s) failed:
See the workflow run for Playwright reports and logs. |
The base blockExplorerUrl already ends with /explorer.
melianessa
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
EMB-395
Why was it implemented this way?
Lighter's explorer doesn't expose
/address/<wallet>— it only supports/explorer/logs/<hash>for transactions and/explorer/accounts/<index>for accounts. The widget builthttps://lighter.exchange/explorer/address/<wallet>fromblockExplorerUrls, which 404'd.Followed the existing
explorerPathOverridespattern inuseExplorer.ts(already used for SUI and TVM) and added aChainId.LTRentry. This keeps the resolution logic centralized and is the minimal, contained change.Caveat: Lighter accounts are keyed by a numeric index resolved from the L1 wallet via an API call (
/api/v1/accountsByL1Address). The widget can't do that resolution synchronously, so the address link won't deep-link to the exact account. It now lands on the/explorer/accounts/<wallet>route, which the SPA serves (no HTTP 404) — satisfying the ticket's acceptance criterion.Visual showcase (Screenshots or Videos)
N/A — link generation change only.
Checklist before requesting a review