Off-by-1 in JSON string escaping#1331
Closed
qu1j0t3 wants to merge 1 commit into
Closed
Conversation
Member
|
I'm sorry, but we cannot accept pull requests, please see the readme https://github.com/lift/framework/blob/master/README.md for some information about it. Thank you. Diego |
Author
|
Please re-open this issue to track the underlying bug, even if the pull request can't be used. Just reference this commit for proposed fix: qu1j0t3@375f741 |
Member
|
Diego was kind enough to point you to the README. If you read it, you will find that the proper procedure for raising issues in Lift is to post to the Lift mailing list. Please do that and we'll see what we can do. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This was a bug which affected a deployed application (with v2.4). Hope you can consider this fix.
(Also, just curious, why not c.toInt instead of c:Int; and what is the purpose of the other two range checks? Are they needed?)
--Toby
PS. Was not able to do a test build at this time, I only have JDK 1.5 (sbt 0.7.7) on this machine.