Midair Collision: Fix issue where binding an href and an onclick together could fail.#1692
Merged
Conversation
This particularly manifested when the attribute whose href we wanted to fix (e.g., the `href` attribute on an `a` element or the `action` attribute on a `form` element) also had an event handler (e.g. `onclick`). The code that fixed the href failed to pass on the event handlers that had been seen so far to the attribute-fixing chain, so they got lost before they could be applied.
Shadowfiend
force-pushed
the
midair-collision
branch
from
4bdce95 to
ed42f67
Compare
We were calling fixAttrs with attrs.next in five places, which meant it was a bit error prone. We now do it up front so the call can be changed in one place.
Member
|
+1 Works for me. |
Member
Author
|
Okay, all passing, so let's do it. |
Shadowfiend
added a commit
that referenced
this pull request
Apr 19, 2015
Midair Collision: Fix issue where binding an `href` and an `onclick` together could fail. This only manifested when the onclick came before the href on an a element, and probably also manifested if you bound an onsubmit on a form that had an action attribute. The cause was just that I had forgotten to properly pass on already-seen event attributes when processing the href attributes, so we lost them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only manifested when the
onclickcame before thehrefon anaelement, and probably also manifested if you bound anonsubmiton a form that had an
actionattribute. The cause was just that I hadforgotten to properly pass on already-seen event attributes when
processing the href attributes, so we lost them.
Fixes #1691 .