Implement ParamFailure chaining for ~>#1693
Merged
Merged
Conversation
Now, when ~> is invoked in a ParamFailure, the existing ParamFailure will be chained, thereby preserving the original param that was attached.
Member
|
Looks like all of these are failing due to Iran's switch to daylight savings happening on the 22nd of March… Going to look at it again tomorrow and see if things are behaving better. |
Member
Author
|
Going to wait a few more days before merging this. Would love some feedback if you folks have time, but barring that I'm going to merging this soon! |
Member
Author
Only on openjdk 7.... that's weird. |
Member
|
Lookin goood! |
Shadowfiend
added a commit
that referenced
this pull request
Apr 20, 2015
Implement ParamFailure chaining for ~> Now, when ~> is invoked in a ParamFailure, the existing ParamFailure will be chained, thereby preserving the original param that was attached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, when ~> is invoked in a ParamFailure, the existing ParamFailure
will be chained, thereby preserving the original param that was
attached.
closes #1680