Null-Anti-Null: Don't assume postPageFunctions are Some.#1694
Merged
Conversation
When generating post-page JavaScript, we were assuming that because our first access of the post-page functions was non-empty, all of them would be. This led to occasional .get-related NullPointerExceptions. We now allow for later calls to the post-page functions to be None, and simply assume we have no more functions to fetch once we get a None for them.
Member
Author
|
Once this guy gets passing, I'm going to go ahead and merge 'im. |
Member
Author
|
Success! |
Shadowfiend
added a commit
that referenced
this pull request
Apr 20, 2015
Null-Anti-Null: Don't assume postPageFunctions are Some. When generating post-page JavaScript, we were assuming that because our first access of the post-page functions was non-empty, all of them would be. This led to occasional .get-related NullPointerExceptions. We now allow for later calls to the post-page functions to be None, and simply assume we have no more functions to fetch once we get a None for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating post-page JavaScript, we were assuming that because our first
access of the post-page functions was non-empty, all of them would be. This led
to occasional .get-related NullPointerExceptions. We now allow for later calls
to the post-page functions to be None, and simply assume we have no more
functions to fetch once we get a None for them.
Fixess #1689 .