Optimize JsonAST.appendEscapedString character insertion#1706
Merged
Conversation
Member
|
Can you please add yourself to the contributor file for me per the contributing guidelines? :) |
Member
There was a problem hiding this comment.
Why do we need the if-statement? Is this part of ensuring the correct append is invoked?
Author
There was a problem hiding this comment.
The isEmpty branch allows the character to be inserted directly instead of getting converted to a string, which incurs the additional overhead.
Author
|
I am currently on line 23 of the contributor agreement . https://github.com/lift/framework/blob/master/contributors.md#name-23 |
Member
|
I'm going to fix the formatting on the if statement and add a comment indicating what it's doing there, and then merge manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitting a pull request based on mailing list discussion https://groups.google.com/forum/#!topic/liftweb/PD5GJYCBmx4 .
https://github.com/lift/framework/blob/master/contributors.md already contains the appropriate info.