Fix BaseParsers ws parser to not match newlines.#1733
Merged
Conversation
In lift-markdown, BaseParsers was using a regex containing `\v` to indicate a vertical tab. As of Java 8, `\v` refers to a character class that contains all vertical whitespace, including newlines. We now explicitly use the unicode value for vertical tab in the regex, fixing the failing test in Java 8 and generally making things work as expected.
Member
|
👍 |
farmdawgnation
added a commit
that referenced
this pull request
Nov 25, 2015
Fix BaseParsers ws parser to not match newlines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In lift-markdown, BaseParsers was using a regex containing
\vto indicate avertical tab. As of Java 8,
\vrefers to a character class that contains allvertical whitespace, including newlines. We now explicitly use the unicode
value for vertical tab in the regex, fixing the failing test in Java 8 and
generally making things work as expected.
See initial report from @farmdawgnation .