CSS URL prefixer comma fix, % fix, and specs#1734
Merged
Merged
Conversation
We can't rename CssHelpers proper, but CssParser becomes the much clearer CssUrlPrefixer, which is what it actually does. fixCSS becomes fixCss, and we leave deprecation warnings for the old invocations.
CssHelpersSpec is properly capitalized despite the fact that it's hard for us to recapitalize CSSHelper without breaking things; it reflects the proper capitalization approach in Lift. It also tests several common scenarios, and verifies that the URL prefixer does not change the quoting type that is used in the source CSS. This is important for URLs that may contain unescaped single quotes inside double quotes or vice versa. Additionally, we verify support for commas and other special characters. This yields fixes for comma support and percent sign support.
Member
Author
|
I'll be merging this around the end of the week assuming no feedback :) |
Member
Author
|
Seeing no feedback, in we go! |
Shadowfiend
added a commit
that referenced
this pull request
Dec 5, 2015
CSS URL prefixer comma fix, % fix, and specs While fixing #1732, did some renaming (with deprecations), added a spec for CssUrlPrefixer, and fixed the originally-reported comma issue, the same issue with supporting % in CSS URLs, as well as fixing the parser's insistence on using single quotes to wrap a URL even when the original CSS either had no quotes or double quotes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While fixing #1732, did some renaming (with deprecations), added a spec
for
CssUrlPrefixer, and fixed the originally-reported comma issue, the sameissue with supporting
%in CSS URLs, as well as fixing the parser's insistenceon using single quotes to wrap a URL even when the original CSS either had no
quotes or double quotes.
Biggest thing I think needs review here beyond the fixes is that any old classes
or methods are still accessible at their old names with deprecation.
Closes #1732 .