Making the Msgs fade and effect scripts append to lift's page script#1737
Merged
Conversation
instead of using the inlining tailScript function.
Member
|
Should we also nuke the only other invocation of |
Member
Author
|
Sounds good to me, sry I somehow missed that one ;) will go ahead and update the PR |
Msg.effects with the new appendScript function. This was the last use of the tailScript function so removing it from Msgs.
Member
Author
|
@Shadowfiend PR is updated the tailScript function is removed as it is no longer referenced. |
Member
There was a problem hiding this comment.
Maybe “appends JavaScript to the current page's page script that…” rather than “appends a script element”? Definitely it's not appending an element.
Member
|
Lookin' good! Quick scaladoc comment, but other than that I'm diggin' it! |
Member
Author
|
@Shadowfiend scaladoc is updated lmkwut |
Member
|
Looks good! 👍 and merging so I can check that lift/lift_30_sbt#2 works as expected! |
Shadowfiend
added a commit
that referenced
this pull request
Dec 3, 2015
Making the Msgs fade and effect scripts append to lift's page script Instead of (as in lift 2.6) using the in-lining tailScript function Msgs fade and effect scripts will now instead append to lifts page script. The change makes it better align with Lifts CSP settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of (as in lift 2.6) using the in-lining tailScript function Msgs fade and effect scripts will now instead append to lifts page script. The change makes it better align with Lifts CSP settings.