feat: Rework "Send" flow#138
Merged
fmorency merged 28 commits intoliftedinit:mainfrom Sep 11, 2023
Merged
Conversation
✅ Deploy Preview for lifted-alberto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
@fmorency This one is also ready for review. I think my organization permissions must have changed because I can't request reviewers or self-assign anymore. |
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 33.93% 34.08% +0.14%
==========================================
Files 88 88
Lines 2260 2265 +5
Branches 656 659 +3
==========================================
+ Hits 767 772 +5
Misses 1482 1482
Partials 11 11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Stanley Jones <stanley@sunshocked.com> Co-authored-by: Félix C. Morency <1102868+fmorency@users.noreply.github.com>
Signed-off-by: Félix C. Morency <1102868+fmorency@users.noreply.github.com> Co-authored-by: Félix C. Morency <1102868+fmorency@users.noreply.github.com>
stanleyjones
force-pushed
the
rework-send
branch
from
6079d08 to
94ef268
Compare
Contributor
Author
|
Ah crap, I tried to get rid of the extra commits and made it worse. Hold on. |
fmorency
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #134 .
Before
No Asset Selected
Asset Selected
Now
No Asset Selected
Asset Selected
(I added the "required" asterisk after taking these screenshots.)