feat: Import/Export Contacts#127
Merged
fmorency merged 14 commits intoliftedinit:mainfrom Aug 3, 2023
Merged
Conversation
✅ Deploy Preview for lifted-alberto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stanleyjones
commented
Jul 27, 2023
Contributor
Author
stanleyjones
left a comment
stanleyjones
left a comment
There was a problem hiding this comment.
Some thoughts...
fmorency
requested changes
Jul 28, 2023
Contributor
fmorency
left a comment
fmorency
left a comment
There was a problem hiding this comment.
Looking good! Can you add error handling/tests to this PR as well?
Thanks!
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 34.33% 33.84% -0.49%
==========================================
Files 88 88
Lines 2234 2266 +32
Branches 648 656 +8
==========================================
Hits 767 767
- Misses 1456 1488 +32
Partials 11 11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
SUCCESS 
WARNING 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCREENSHOT
Working but no error handling or anything yet.
Closes #123 .