Skip to content

feat: Expose package version in build #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stanleyjones merged 2 commits into from
Feb 13, 2023
Merged

feat: Expose package version in build #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e76b71
feat: Expose package version in build
stanleyjones Feb 13, 2023
c6cede7
Update package.json
stanleyjones Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
SKIP_PREFLIGHT_CHECK=true
HTTPS=true
REACT_APP_WEB3AUTH_NETWORK=testnet
REACT_APP_WEB3AUTH_CLIENTID=BKj3lr6GfN2CnvO4CIKo5fuoCg_TpHsAPK7R8lbl6kUlz0CAH_5mFNswScEb7M6szV4hd1Tkwa2oPZ9KiXJB-44
REACT_APP_WEB3AUTH_CLIENTID=BKj3lr6GfN2CnvO4CIKo5fuoCg_TpHsAPK7R8lbl6kUlz0CAH_5mFNswScEb7M6szV4hd1Tkwa2oPZ9KiXJB-44
REACT_APP_VERSION=${npm_package_version}
Copy link
Copy Markdown
Contributor Author

@stanleyjones stanleyjones Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get the package version from package.json.

10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,13 @@ available.

- Lifted web3auth dashboard: https://dashboard.web3auth.io/
- Users dashboard: https://app.openlogin.com/

## Version

Alberto is currently pre-release alpha software, so incrementing the version
(which will trigger creating a GitHub Release) is best accomplished with the
following command:

```sh
npm version prerelease --preid alpha
Copy link
Copy Markdown
Contributor Author

@stanleyjones stanleyjones Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generate an actually useful version string (instead of just 0.1.0). By using this command, npm will:

  • Bump the version (i.e. 0.1.0-alpha.8 -> 0.1.0-alpha.9)
  • Update package.json
  • Commit all changes
  • Create a tag (i.e. 0.1.0-alpha.9)
  • Push changes and tags to GitHub

```
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
"eject": "react-scripts eject",
"test": "react-scripts test",
"prepare": "husky install",
"test:e2e": "npx playwright test --config=./e2e/playwright.config.ts"
"test:e2e": "npx playwright test --config=./e2e/playwright.config.ts",
"version": "git add -A",
"postversion": "git push --no-verify && git push --tags --no-verify"
},
"dependencies": {
"@beam-australia/react-env": "^3.1.1",
Expand Down
1 change: 1 addition & 0 deletions public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<meta name="theme-color" content="#000000" />
<link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" />
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" />
<meta name="version" content="%REACT_APP_VERSION%" />
Copy link
Copy Markdown
Contributor Author

@stanleyjones stanleyjones Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, actually expose the more useful version in the front-end code.

</head>
<body>
<noscript>You need to enable JavaScript to run this app.</noscript>
Expand Down