Skip to content

feat: migration whitelist#170

Closed
fmorency wants to merge 102 commits intoliftedinit:mainfrom
fmorency:migration-whitelist
Closed

feat: migration whitelist#170
fmorency wants to merge 102 commits intoliftedinit:mainfrom
fmorency:migration-whitelist

Conversation

@fmorency
Copy link
Copy Markdown
Contributor

@fmorency fmorency commented Apr 7, 2025

Contains #159

See fmorency#1 for the change description.

@fmorency fmorency requested a review from Copilot April 7, 2025 20:07
@fmorency fmorency self-assigned this Apr 7, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 7, 2025

Deploy Preview for lifted-alberto ready!

Name Link
🔨 Latest commit 6693920
🔍 Latest deploy log https://app.netlify.com/sites/lifted-alberto/deploys/67f53e181f798a0008cbe05e
😎 Deploy Preview https://deploy-preview-170--lifted-alberto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 88 out of 93 changed files in this pull request and generated 1 comment.

Files not reviewed (5)
  • .env: Language not supported
  • .env.production: Language not supported
  • .env.staging: Language not supported
  • e2e/.env.example: Language not supported
  • package.json: Language not supported

Comment thread config-overrides.js
@fmorency fmorency marked this pull request as ready for review April 8, 2025 15:20
@fmorency fmorency requested a review from Copilot April 8, 2025 15:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 76.09195% with 208 lines in your changes missing coverage. Please review.

Project coverage is 45.47%. Comparing base (a30b638) to head (6693920).

Files with missing lines Patch % Lines
src/features/token-migration/event-validation.tsx 32.07% 36 Missing ⚠️
src/features/accounts/queries.ts 6.25% 30 Missing ⚠️
...ation/components/migration-form/migration-form.tsx 79.61% 21 Missing ⚠️
...components/migration-details/migration-details.tsx 86.15% 17 Missing and 1 partial ⚠️
src/features/accounts/api/get-account-info.ts 0.00% 15 Missing ⚠️
src/features/token-migration/queries.ts 13.33% 13 Missing ⚠️
src/features/network/queries.ts 8.33% 11 Missing ⚠️
.../txn-list/txn-list-item/multisig-txn-list-item.tsx 8.33% 11 Missing ⚠️
src/features/accounts/api/create-account.ts 0.00% 9 Missing ⚠️
src/features/accounts/stores/accounts-store.ts 14.28% 6 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #170       +/-   ##
===========================================
+ Coverage   35.33%   45.47%   +10.14%     
===========================================
  Files          91      122       +31     
  Lines        2414     3219      +805     
  Branches      683      894      +211     
===========================================
+ Hits          853     1464      +611     
- Misses       1549     1740      +191     
- Partials       12       15        +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 88 out of 93 changed files in this pull request and generated 2 comments.

Files not reviewed (5)
  • .env: Language not supported
  • .env.production: Language not supported
  • .env.staging: Language not supported
  • e2e/.env.example: Language not supported
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

src/features/accounts/api/create-account.ts:323

  • Consider renaming the parameter 'TokenMigrationFormData' to 'tokenMigrationFormData' to follow camelCase conventions.
function onCreateClick(TokenMigrationFormData: unknown) {

Comment thread config-overrides.js
Comment thread e2e/tests/accounts.spec.ts
Copy link
Copy Markdown

@jgryffindor jgryffindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK, looks good! Out in QA

@fmorency
Copy link
Copy Markdown
Contributor Author

fmorency commented Apr 9, 2025

Merged in #159

@fmorency fmorency closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants