Skip to content

fix: 1:10 split#173

Merged
fmorency merged 2 commits intoliftedinit:mainfrom
fmorency:1-10-split
Jun 3, 2025
Merged

fix: 1:10 split#173
fmorency merged 2 commits intoliftedinit:mainfrom
fmorency:1-10-split

Conversation

@fmorency
Copy link
Copy Markdown
Contributor

This pull request includes updates to the token migration logic and associated user-facing text to reflect a change in the token migration ratio and validation rules. The most important changes include modifying the migration ratio from 1:100 to 1:10, adjusting validation thresholds for token amounts, and updating the terms and conditions to align with the new ratio.

Updates to token migration ratio:

Validation rule adjustments:

@fmorency fmorency requested a review from Copilot May 30, 2025 17:58
@fmorency fmorency self-assigned this May 30, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented May 30, 2025

Deploy Preview for lifted-alberto ready!

Name Link
🔨 Latest commit 5d22cfc
🔍 Latest deploy log https://app.netlify.com/projects/lifted-alberto/deploys/6839f6c093d365000813ec58
😎 Deploy Preview https://deploy-preview-173--lifted-alberto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the token migration ratio from 1:100 to 1:10 and aligns the validation rules and user-facing text to match the new ratio.

  • Modified the migration ratio text in both the terms and conditions and the form step from 1:100 to 1:10
  • Adjusted validation logic: raised the minimum token amount from 1e-8 to 1e-7 and reduced allowable decimal places from 8 to 7

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/features/token-migration/components/migration-form/terms-and-conditions.tsx Replaced “1-for-100” with “1-for-10” in the migration terms
src/features/token-migration/components/migration-form/amount-asset-step.tsx Updated validation thresholds (1e-8 → 1e-7, 8 → 7 decimals) and ratio examples
Comments suppressed due to low confidence (2)

src/features/token-migration/components/migration-form/amount-asset-step.tsx:80

  • [nitpick] The error message uses scientific notation (1e-7), which can be unclear to end users—consider displaying '0.0000001' to match the examples and improve readability.
        "Amount must be greater than 1e-7 and less than or equal to your balance",

src/features-token-migration/components/migration-form/amount-asset-step.tsx:79

  • Add or update unit tests to cover the new minimum amount (1e-7) and decimal place limit (7) to verify the adjusted validation logic.
.test(
          "is-amount-in-range",

@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.61%. Comparing base (0c3e31b) to head (5d22cfc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   45.61%   45.61%           
=======================================
  Files         122      122           
  Lines        3229     3229           
  Branches      897      897           
=======================================
  Hits         1473     1473           
  Misses       1741     1741           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fmorency fmorency requested a review from jgryffindor May 30, 2025 18:14
Copy link
Copy Markdown

@jgryffindor jgryffindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@fmorency fmorency merged commit 676d59c into liftedinit:main Jun 3, 2025
10 checks passed
@fmorency fmorency deleted the 1-10-split branch June 3, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants