Skip to content

fix: focus trap#177

Merged
fmorency merged 1 commit intoliftedinit:mainfrom
fmorency:fix-focus
Oct 24, 2025
Merged

fix: focus trap#177
fmorency merged 1 commit intoliftedinit:mainfrom
fmorency:fix-focus

Conversation

@fmorency
Copy link
Copy Markdown
Contributor

This pull request introduces a minor update to the AddAccountModal component. The main change is the adjustment of focus management props to improve modal accessibility and user experience.

  • Accessibility improvements: Disabled focus trapping, automatic focus, and cross-frame focus locking in the AddAccountModal by setting trapFocus, autoFocus, and lockFocusAcrossFrames to false in add-account-modal.tsx.

@fmorency fmorency requested a review from Copilot October 24, 2025 15:33
@fmorency fmorency self-assigned this Oct 24, 2025
@fmorency fmorency marked this pull request as ready for review October 24, 2025 15:33
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 24, 2025

Deploy Preview for lifted-alberto ready!

Name Link
🔨 Latest commit 2e1114d
🔍 Latest deploy log https://app.netlify.com/projects/lifted-alberto/deploys/68fb9c42829ea800083c2897
😎 Deploy Preview https://deploy-preview-177--lifted-alberto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses focus management issues in the AddAccountModal component by disabling focus trapping, automatic focus, and cross-frame focus locking to improve modal accessibility and user experience.

  • Disabled focus trapping to allow users to navigate outside the modal
  • Disabled automatic focus to prevent unexpected focus behavior on modal open
  • Disabled cross-frame focus locking to improve compatibility with iframe contexts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.31%. Comparing base (905a133) to head (2e1114d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   52.30%   52.31%   +0.01%     
==========================================
  Files         184      184              
  Lines        9965     9968       +3     
  Branches      444      444              
==========================================
+ Hits         5212     5215       +3     
  Misses       4738     4738              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fmorency fmorency merged commit fac26e9 into liftedinit:main Oct 24, 2025
10 checks passed
@fmorency fmorency deleted the fix-focus branch October 24, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants