fix: focus trap#177
Merged
fmorency merged 1 commit intoliftedinit:mainfrom Oct 24, 2025
Merged
Conversation
✅ Deploy Preview for lifted-alberto ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses focus management issues in the AddAccountModal component by disabling focus trapping, automatic focus, and cross-frame focus locking to improve modal accessibility and user experience.
- Disabled focus trapping to allow users to navigate outside the modal
- Disabled automatic focus to prevent unexpected focus behavior on modal open
- Disabled cross-frame focus locking to improve compatibility with iframe contexts
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 52.30% 52.31% +0.01%
==========================================
Files 184 184
Lines 9965 9968 +3
Branches 444 444
==========================================
+ Hits 5212 5215 +3
Misses 4738 4738
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor update to the
AddAccountModalcomponent. The main change is the adjustment of focus management props to improve modal accessibility and user experience.AddAccountModalby settingtrapFocus,autoFocus, andlockFocusAcrossFramestofalseinadd-account-modal.tsx.